more idiomatic way to check size for nil

Max Jonas Werner · Max Jonas Werner · commit a5b678f58dc3 · 2022-04-22T10:27:36.000+02:00
Signed-off-by: Max Jonas Werner &lt;mail@makk.es&gt;
diff --git a/controllers/helmrepository_controller.go b/controllers/helmrepository_controller.go
@@ -256,8 +256,8 @@ func (r *HelmRepositoryReconciler) notify(oldObj, newObj *sourcev1.HelmRepositor
 		}
 
 		humanReadableSize := "unknown size"
-		if newObj.Status.Artifact.Size != nil {
-			humanReadableSize = fmt.Sprintf("size %s", units.HumanSize(float64(*newObj.Status.Artifact.Size)))
+		if size := newObj.Status.Artifact.Size; size != nil {
+			humanReadableSize = fmt.Sprintf("size %s", units.HumanSize(float64(*size)))
 		}
 
 		var oldChecksum string

Original file line number	Diff line number	Diff line change
`@@ -256,8 +256,8 @@ func (r HelmRepositoryReconciler) notify(oldObj, newObj sourcev1.HelmRepositor`
`256`	`256`	`}`
`257`	`257`
`258`	`258`	`humanReadableSize := "unknown size"`
`259`		`- if newObj.Status.Artifact.Size != nil {`
`260`		`- humanReadableSize = fmt.Sprintf("size %s", units.HumanSize(float64(*newObj.Status.Artifact.Size)))`
	`259`	`+ if size := newObj.Status.Artifact.Size; size != nil {`
	`260`	`+ humanReadableSize = fmt.Sprintf("size %s", units.HumanSize(float64(*size)))`
`261`	`261`	`}`
`262`	`262`
`263`	`263`	`var oldChecksum string`