Skip to content

Commit 2d69758

Browse files
alvarobcpradoAlvaro Prado
andauthored
fix(package_info_plus): add support for file scheme on web (#3345)
Co-authored-by: Alvaro Prado <[email protected]>
1 parent e38b4c3 commit 2d69758

File tree

2 files changed

+21
-0
lines changed

2 files changed

+21
-0
lines changed

packages/package_info_plus/package_info_plus/example/integration_test/package_info_plus_web_test.dart

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,25 @@ void main() {
217217
'chrome-extension://abcdefgh/a/b/c/version.json?cachebuster=1'),
218218
);
219219
});
220+
221+
testWidgets('Get correct versionJsonUrl for file', (tester) async {
222+
expect(
223+
plugin.versionJsonUrl('file://abcdefgh', 1),
224+
Uri.parse('file:///version.json?cachebuster=1'),
225+
);
226+
expect(
227+
plugin.versionJsonUrl('file://abcdefgh/a/b/c', 1),
228+
Uri.parse('file:///a/b/c/version.json?cachebuster=1'),
229+
);
230+
expect(
231+
plugin.versionJsonUrl('file://abcdefgh/#my-page', 1),
232+
Uri.parse('file:///version.json?cachebuster=1'),
233+
);
234+
expect(
235+
plugin.versionJsonUrl('file://abcdefgh/a/b/c/#my-page', 1),
236+
Uri.parse('file:///a/b/c/version.json?cachebuster=1'),
237+
);
238+
});
220239
},
221240
);
222241

packages/package_info_plus/package_info_plus/lib/src/package_info_plus_web.dart

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,8 @@ extension _UriOrigin on Uri {
123123
String get _origin {
124124
if (isScheme('chrome-extension')) {
125125
return '$scheme://$host';
126+
} else if (isScheme('file')) {
127+
return '$scheme://';
126128
}
127129
return origin;
128130
}

0 commit comments

Comments
 (0)