Skip to content

Added type as T, else the assert statement fails #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Neelansh-ns
Copy link

Passing the type as generic T, else even though a Factory is registered, the isRegistered() would return false. As _scopes[T] would return null.

@escamoteur
Copy link
Collaborator

I'm sorry for the late response, but I had to take a longer break due to health issues.

I checked the code and it's not clear to my why the current code fails, because the generic type T is passed to _findFirstFactoryByNameAndTypeOrNull can you provide a test where the function fails?

@escamoteur
Copy link
Collaborator

closing this because of no resonse

@escamoteur escamoteur closed this May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants