Added flag to suppress the printing of error messages. #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… catching the error themselves and logging it this print is intrusive and should not appear. Default set to false to maintain past behaviour.
|
Hi, thanks. this is a valid improvement. could you please also add comments to the property and add it to the readme? |
|
I know that it's been a long time, but I had to make a longer break due to health issues. I will merge your PR but change it to a public property inside of GetIt call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added flag to suppress the printing of error messages.
When a user is catching the error themselves and logging it this print is intrusive and should not appear. Default set to false to maintain past behaviour.