Fix StateError when unregistering non-async singletons other singletons are dependent on #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @escamoteur, could you please check this pull request? |
|
Hi, sorry for not looking into this earlier, but I had some mental health problems the last half year. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When registering a singleton that other singletons are dependent on, the instance's
objectsWaitinglist gets filled with the dependent singletons. This list is cleared for async singletons, when they have been created, as of fix for #210.The list is not cleared for non-async singletons, which results in them being unable to be unregistered at any time with the
StateError( 'There are still other objects waiting for this instance so signal ready'.This PR fixes the unexpected exception by clearing the
objectsWaitingwhen a non-async singleton has been initialized.