feature(unregister): fixes some appointments from PR #15 #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name, and also dispose resources in the process Signed-off-by: Jhionan <[email protected]>
…nge named parameters for positional renaming second parameter from disposal to disposingFunction Signed-off-by: Jhionan <[email protected]>
escamoteur
approved these changes
Sep 4, 2019
lib/get_it.dart
Outdated
| /// if you need to dispose any resources you can do it using [disposal] function | ||
| /// that provides a instance of your class to be disposed | ||
| void unregister<T>({String instanceName, Function(T) disposal}) { | ||
| assert(_factoriesByName.containsKey(instanceName) || _factories.containsKey(T), 'Nor Type ${T.toString()} or instance Name must not be null'); |
There was a problem hiding this comment.
Sorry, my fault, I missed that you passed named parameters. I will merge and change that back.
There was a problem hiding this comment.
Nice. I start updating readme and just realize that optional positional parameters is a bad idea in this case, because if you want to remove a typed instance and use the dispose function you would use something like unregister<T>( _ , function);
|
Could you also update the readme after I merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed adicional map.remove on wrong place, changed optional named parameters to optional positional and renaming disposal function to disposingFunction