Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit df6a66a

Browse files
committed
removed nil check and switched away from init
1 parent 32bb3f8 commit df6a66a

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

packages/video_player/video_player_avfoundation/example/ios/RunnerTests/VideoPlayerTests.m

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,12 @@ - (void)testDeregistersFromPlayer {
5151
[videoPlayerPlugin initialize:&error];
5252
XCTAssertNil(error);
5353

54-
FLTCreateMessage *create = [[FLTCreateMessage alloc] init];
55-
create.uri = @"https://flutter.github.io/assets-for-api-docs/assets/videos/bee.mp4";
54+
FLTCreateMessage *create = [FLTCreateMessage
55+
makeWithAsset:nil
56+
uri:@"https://flutter.github.io/assets-for-api-docs/assets/videos/bee.mp4"
57+
packageName:nil
58+
formatHint:nil
59+
httpHeaders:@{}];
5660
FLTTextureMessage *textureMessage = [videoPlayerPlugin create:create error:&error];
5761
XCTAssertNil(error);
5862
XCTAssertNotNil(textureMessage);
@@ -123,8 +127,11 @@ - (void)testHLSControls {
123127
[videoPlayerPlugin initialize:&error];
124128
XCTAssertNil(error);
125129

126-
FLTCreateMessage *create = [[FLTCreateMessage alloc] init];
127-
create.uri = uri;
130+
FLTCreateMessage *create = [FLTCreateMessage makeWithAsset:nil
131+
uri:uri
132+
packageName:nil
133+
formatHint:nil
134+
httpHeaders:@{}];
128135
FLTTextureMessage *textureMessage = [videoPlayerPlugin create:create error:&error];
129136

130137
NSNumber *textureId = textureMessage.textureId;

packages/video_player/video_player_avfoundation/ios/Classes/FLTVideoPlayerPlugin.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ - (instancetype)initWithURL:(NSURL *)url
179179
frameUpdater:(FLTFrameUpdater *)frameUpdater
180180
httpHeaders:(nonnull NSDictionary<NSString *, NSString *> *)headers {
181181
NSDictionary<NSString *, id> *options = nil;
182-
if (headers != nil && [headers count] != 0) {
182+
if ([headers count] != 0) {
183183
options = @{@"AVURLAssetHTTPHeaderFieldsKey" : headers};
184184
}
185185
AVURLAsset *urlAsset = [AVURLAsset URLAssetWithURL:url options:options];

0 commit comments

Comments
 (0)