Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

Commit 16d759e

Browse files
committed
fix the nnbd plugin test exclusion logic
1 parent 05879a3 commit 16d759e

File tree

3 files changed

+18
-2
lines changed

3 files changed

+18
-2
lines changed

.cirrus.yml

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,16 @@ task:
3939
- flutter channel $CHANNEL
4040
- ./script/incremental_build.sh test
4141
- name: analyze
42+
env:
43+
matrix:
44+
CHANNEL: "master"
45+
CHANNEL: "stable"
4246
script: ./script/incremental_build.sh analyze
4347
- name: build_all_plugins_apk
48+
env:
49+
matrix:
50+
CHANNEL: "master"
51+
CHANNEL: "stable"
4452
script:
4553
# TODO(jackson): Allow web plugins once supported on stable
4654
# https://github.com/flutter/flutter/issues/42864
@@ -143,6 +151,10 @@ task:
143151
- xcrun simctl create Flutter-iPhone com.apple.CoreSimulator.SimDeviceType.iPhone-X com.apple.CoreSimulator.SimRuntime.iOS-13-3 | xargs xcrun simctl boot
144152
matrix:
145153
- name: build_all_plugins_ipa
154+
env:
155+
matrix:
156+
CHANNEL: "master"
157+
CHANNEL: "stable"
146158
script:
147159
# TODO(jackson): Allow web plugins once supported on stable
148160
# https://github.com/flutter/flutter/issues/42864
@@ -196,6 +208,10 @@ task:
196208
activate_script: pub global activate flutter_plugin_tools
197209
matrix:
198210
- name: build_all_plugins_app
211+
env:
212+
matrix:
213+
CHANNEL: "master"
214+
CHANNEL: "stable"
199215
script:
200216
- flutter channel master
201217
- ./script/build_all_plugins_app.sh macos

script/build_all_plugins_app.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ readonly EXCLUDED=$(IFS=, ; echo "${EXCLUDED_PLUGINS_LIST[*]}")
4646

4747
ALL_EXCLUDED=($EXCLUDED)
4848
# Exclude nnbd plugins from stable.
49-
if [[ "$CHANNEL" -eq "stable" ]]; then
49+
if [ "$CHANNEL" == "stable" ]; then
5050
ALL_EXCLUDED=("$EXCLUDED,$EXCLUDED_PLUGINS_FROM_STABLE")
5151
fi
5252

script/incremental_build.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ fi
1616
# Plugins that are excluded from this task.
1717
ALL_EXCLUDED=("")
1818
# Exclude nnbd plugins from stable.
19-
if [[ "$CHANNEL" -eq "stable" ]]; then
19+
if [ "$CHANNEL" == "stable" ]; then
2020
ALL_EXCLUDED=($EXCLUDED_PLUGINS_FROM_STABLE)
2121
echo "Excluding the following plugins: $ALL_EXCLUDED"
2222
fi

0 commit comments

Comments
 (0)