[camera_android_camerax] Java style improvements #9234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ash2moon
reviewed
May 30, 2025
| @@ -33,7 +34,7 @@ static class AnalyzerImpl implements Analyzer { | |||
| } | |||
|
|
|||
| @Override | |||
| public void analyze(@NonNull androidx.camera.core.ImageProxy image) { | |||
| public void analyze(@NonNull ImageProxy image) { | |||
| api.getPigeonRegistrar() | |||
| .runOnMainThread( | |||
| new ProxyApiRegistrar.FlutterMethodRunnable() { | |||
There was a problem hiding this comment.
I think this could be simplified using a lambda instead of an anonymous inner class. Maybe consider using a class level method you can just pass to further reduce nesting too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes Java style improvements that roughly follow https://google.github.io/styleguide/javaguide.html.
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3