-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[android_camera_camerax] Fix incorrect camera mirroring for front cameras on devices using ImageReader
Impeller backend
#9233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+246
−25
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7b3809a
mirror camera
camsim99 1351c20
fix tests + bump version
camsim99 ceb9865
added mirroring tests
jesswrd 50897b2
resolved conflicts
jesswrd fe4ffb3
updated changelog
jesswrd bdf32a7
formatted files
jesswrd e2fba01
added helper function. has to check entire matrix
jesswrd c4b1fd6
Revert "added helper function. has to check entire matrix"
jesswrd 0139263
added helper function. has to check entire matrix (take 2)
jesswrd a0c9bc9
Merge branch 'main' into camx_mirror_2
jesswrd ad702cc
formatted tests
jesswrd de19674
updated changelog
jesswrd 0061ab0
Update packages/camera/camera_android_camerax/CHANGELOG.md
reidbaker 541f537
add comment
camsim99 5fe7d84
Merge remote-tracking branch 'refs/remotes/origin/camx_mirror_2' into…
camsim99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is == 1 the correct comparison here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah because
facingSign
maps to thesign
in https://developer.android.com/media/camera/camera2/camera-preview#orientation_calculation, which is 1 for front cameras, -1 for back facing cameras. I'll add a comment to the code!