Skip to content

[camera_web] Remove mocktail dependency. #9195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ksokolovskyi
Copy link
Contributor

@ksokolovskyi ksokolovskyi commented May 3, 2025

Closes flutter/flutter#130757

Description

  • Removes mocktail dependency
  • Adds mockito and build_runner dependencies
  • Updates tests

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@ksokolovskyi ksokolovskyi force-pushed the remove-mocktail-dependency-from-camera-web branch from 40be29e to 2aa5116 Compare May 3, 2025 12:21
@stuartmorgan-g stuartmorgan-g self-requested a review May 6, 2025 19:57
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this cleanup!

@ksokolovskyi
Copy link
Contributor Author

@stuartmorgan-g, do we need a second approval, or can we proceed?

@stuartmorgan-g
Copy link
Contributor

flutter-hackers members only need one approval, so you can add the autosubmit label any time.

@ksokolovskyi ksokolovskyi added the autosubmit Merge PR when tree becomes green via auto submit App label May 29, 2025
@auto-submit auto-submit bot merged commit 79f4377 into flutter:main May 29, 2025
82 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 29, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 29, 2025
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request May 29, 2025
flutter/packages@5743798...4463066

2025-05-29 [email protected] Allow tests to
use macOS 14 or 15.5 (flutter/packages#9328)
2025-05-29 [email protected] [camera_web] Remove mocktail
dependency. (flutter/packages#9195)
2025-05-28 [email protected] Roll Flutter from
4372bfb to 0e536eb (27 revisions) (flutter/packages#9334)
2025-05-28 [email protected] [camera_avfoundation]
Implementation swift migration - part 3.5 (flutter/packages#9254)
2025-05-28 [email protected]
[webview_flutter_wkwebview] Fix `testNilRequest` test for macOS 15.5
(flutter/packages#9330)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera platform-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[camera_web] Remove mocktail dependency.
2 participants