[google_map_flutter] Add style to widget - platform impls #6205
Conversation
stuartmorgan-g
requested review from
hellohuanlin,
reidbaker and
ditman
as code owners
github-actions
bot
added
p: google_maps_flutter
platform-android
platform-ios
platform-web
labels
| // behavior of other platforms where there's no mechanism to return errors | ||
| // from configuration updates. | ||
| try { | ||
| _lastStyles = _mapStyles(update.style); |
There was a problem hiding this comment.
Do we want a test that asserts that _lastStyles remain unchanged when update.style is wrong? (not sure if we want that to be a feature or is a side-effect of this particular implementation)
There was a problem hiding this comment.
That does seem worth testing. I couldn't see a way to add it without adding another kind of ugly test hook, so I did that; let me know if you have a better option. (Long term we may want to wrap that opaque maps object instead of having to add these hooks at this layer.)
There was a problem hiding this comment.
The new hook is fine. There seems to exist a way to fetch styles from the gmaps.GMap object through its MVCObject interface:
map.get('styles')But I'm not sure if whatever that returns is directly comparable with what we pass in!
There was a problem hiding this comment.
We shouldn't need to compare with what we pass in, just the before/after, but I'm getting null from that getter. Maybe this is related to needing to pump things differently in the maps integration tests?
For now I'm just going to land this since it's a pattern we already have, and we can revisit the structure of these tests later if necessary.
|
(Landing without reviews from the others since it's identical to the version already approved in the main PR.) |
stuartmorgan-g
added
the
autosubmit
flutter/packages@353086c...6d02f03 2024-02-28 [email protected] Manual roll Flutter from c30f998 to d00bfe8 (32 revisions) (flutter/packages#6222) 2024-02-28 [email protected] [google_maps_flutter] Add `style` to widget (flutter/packages#6192) 2024-02-28 [email protected] Add library annotations for js interop (flutter/packages#6216) 2024-02-28 [email protected] [google_map_flutter] Add style to widget - platform impls (flutter/packages#6205) 2024-02-28 [email protected] [google_maps_flutter_web] Migrate to package:web (flutter/packages#5254) 2024-02-28 [email protected] [pigeon] Remove heap allocation in generated C++ code (flutter/packages#6196) 2024-02-27 [email protected] [pigeon] Allows kotlin generator to skip error class generation (flutter/packages#6183) 2024-02-27 [email protected] [camerax] Implements `setExposureMode` (flutter/packages#6110) 2024-02-27 [email protected] Roll Flutter from b77560e to c30f998 (12 revisions) (flutter/packages#6211) 2024-02-26 [email protected] Add `InkResponse`, `Material` and fix `Opacity` (flutter/packages#6199) 2024-02-26 [email protected] [url_launcher] Add explicit imports of UIKit (flutter/packages#6208) 2024-02-26 [email protected] [pigeon] Fix tool hangs on verbose sub-processes (flutter/packages#6198) 2024-02-26 [email protected] [tool] Ignore GeneratedPluginRegistrant.swift for `format` (flutter/packages#6195) 2024-02-26 [email protected] Roll Flutter from 1e8dd1e to b77560e (8 revisions) (flutter/packages#6207) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Platform implementations portion of flutter#6192 Adds handling of `MapConfiguration.style` and implements new `getStyleError` method. Part of flutter/flutter#66207
Platform implementations portion of #6192
Adds handling of
MapConfiguration.styleand implements newgetStyleErrormethod.Part of flutter/flutter#66207
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).