Skip to content

[camera] Document -1 return value for getExposureOffsetStepSize #6182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

camsim99
Copy link
Contributor

@camsim99 camsim99 commented Feb 22, 2024

Documents getExposureOffsetStepSize to return -1 if the device does not support exposure compensation. Helps account for camera_android_camerax since CameraX does not return a step size if exposure compensation is not supported.

A follow up to this discussion.

Pre-launch Checklist

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camsim99 camsim99 added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 23, 2024
@auto-submit auto-submit bot merged commit 74eeb29 into flutter:main Feb 23, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 26, 2024
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Feb 26, 2024
flutter/packages@7df2085...353086c

2024-02-26 [email protected] [google_map_flutter] Add style to widget - platform interface (flutter/packages#6197)
2024-02-26 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.4 to 3.24.5 (flutter/packages#6204)
2024-02-25 [email protected] Roll Flutter from f6c1082 to 1e8dd1e (3 revisions) (flutter/packages#6203)
2024-02-24 [email protected] Roll Flutter from 39585e6 to f6c1082 (20 revisions) (flutter/packages#6200)
2024-02-23 [email protected] Roll Flutter from 41581c9 to 39585e6 (31 revisions) (flutter/packages#6194)
2024-02-23 [email protected] [camera] Document -1 return value for `getExposureOffsetStepSize` (flutter/packages#6182)
2024-02-23 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.3 to 3.24.4 (flutter/packages#6184)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LouiseHsu pushed a commit to LouiseHsu/packages that referenced this pull request Mar 7, 2024
…utter#6182)

Documents `getExposureOffsetStepSize` to return -1 if the device does not support exposure compensation. Helps account for `camera_android_camerax` since CameraX does not return a step size if exposure compensation is not supported.

A follow up to [this discussion](flutter#6059 (comment)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autosubmit Merge PR when tree becomes green via auto submit App p: camera
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants