[webview_flutter] Replace deprecated Color.value (#10480)

Replaces the deprecated `Color.value` with the equivalent `Color.toARGB()`. For iOS, where this is not the ideal long-term solution, adds a TODO for a better replacement.

Part of flutter/flutter#159739

## Pre-Review Checklist

[^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

Author: stuartmorgan-g

packages/webview_flutter/webview_flutter_android/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 4.10.7
+
+* Replaces use of deprecated Color.value.
+
 ## 4.10.6
 
 * Updates to Pigeon 26.

packages/webview_flutter/webview_flutter_android/lib/src/android_webview_controller.dart

@@ -648,7 +648,7 @@ class AndroidWebViewController extends PlatformWebViewController {
 
   @override
   Future<void> setBackgroundColor(Color color) =>
-      _webView.setBackgroundColor(color.value);
+      _webView.setBackgroundColor(color.toARGB32());
 
   @override
   Future<void> setJavaScriptMode(JavaScriptMode javaScriptMode) => _webView

packages/webview_flutter/webview_flutter_android/lib/src/legacy/webview_android_widget.dart

@@ -451,7 +451,7 @@ class WebViewAndroidPlatformController extends WebViewPlatformController {
 
     final Color? backgroundColor = creationParams.backgroundColor;
     if (backgroundColor != null) {
-      webView.setBackgroundColor(backgroundColor.value);
+      webView.setBackgroundColor(backgroundColor.toARGB32());
     }
 
     addJavascriptChannels(creationParams.javascriptChannelNames);

packages/webview_flutter/webview_flutter_android/lib/src/legacy/webview_surface_android.dart

@@ -67,7 +67,7 @@ class SurfaceAndroidWebView extends AndroidWebView {
                 // AndroidViewSurface. This switches the WebView to Hybrid
                 // Composition when the background color is not 100% opaque.
                 hybridComposition:
-                    backgroundColor != null && backgroundColor.opacity < 1.0,
+                    backgroundColor != null && backgroundColor.a < 1.0,
                 id: params.id,
                 viewType: 'plugins.flutter.io/webview',
                 // WebView content is not affected by the Android view's layout direction,

packages/webview_flutter/webview_flutter_android/pubspec.yaml

@@ -2,7 +2,7 @@ name: webview_flutter_android
 description: A Flutter plugin that provides a WebView widget on Android.
 repository: https://github.com/flutter/packages/tree/main/packages/webview_flutter/webview_flutter_android
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+webview%22
-version: 4.10.6
+version: 4.10.7
 
 environment:
   sdk: ^3.9.0

packages/webview_flutter/webview_flutter_android/test/android_webview_controller_test.dart

@@ -1868,7 +1868,7 @@ void main() {
 
       await controller.setBackgroundColor(Colors.blue);
 
-      verify(mockWebView.setBackgroundColor(Colors.blue.value)).called(1);
+      verify(mockWebView.setBackgroundColor(Colors.blue.toARGB32())).called(1);
     });
 
     test('setJavaScriptMode', () async {

packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 3.23.4
+
+* Replaces use of deprecated Color.value.
+
 ## 3.23.3
 
 * Updates to Pigeon 26.

packages/webview_flutter/webview_flutter_wkwebview/lib/src/legacy/web_kit_webview_widget.dart

@@ -242,9 +242,11 @@ class WebKitWebViewPlatformController extends WebViewPlatformController {
 
     if (params.backgroundColor != null) {
       unawaited(webView.setOpaque(false));
-      unawaited(webView.setBackgroundColor(Colors.transparent.value));
+      unawaited(webView.setBackgroundColor(Colors.transparent.toARGB32()));
       unawaited(
-        webView.scrollView.setBackgroundColor(params.backgroundColor?.value),
+        webView.scrollView.setBackgroundColor(
+          params.backgroundColor?.toARGB32(),
+        ),
       );
     }
 

packages/webview_flutter/webview_flutter_wkwebview/lib/src/webkit_webview_controller.dart

@@ -651,9 +651,9 @@ class WebKitWebViewController extends PlatformWebViewController {
   Future<void> setBackgroundColor(Color color) {
     return Future.wait(<Future<void>>[
       _webView.setOpaque(false),
-      _webView.setBackgroundColor(Colors.transparent.value),
+      _webView.setBackgroundColor(Colors.transparent.toARGB32()),
       // This method must be called last.
-      _webView.scrollView.setBackgroundColor(color.value),
+      _webView.scrollView.setBackgroundColor(color.toARGB32()),
     ]);
   }
 

packages/webview_flutter/webview_flutter_wkwebview/pigeons/web_kit.dart

@@ -602,6 +602,9 @@ abstract class WKWebsiteDataStore extends NSObject {
 )
 abstract class UIView extends NSObject {
   /// The view’s background color.
+  // TODO(bparrishMines): Using an int here is lossy, and should be replaced
+  //  with a full color representation. See
+  //  https://github.com/flutter/flutter/issues/178870.
   void setBackgroundColor(int? value);
 
   /// A Boolean value that determines whether the view is opaque.