[file_selector] Implement canCreateDirectories across all platforms

Author: danferreira

packages/file_selector/file_selector_android/CHANGELOG.md

@@ -1,5 +1,6 @@
-## NEXT
+## 0.5.3
 
+* Adds `getDirectoryPathWithOptions` and `getDirectoryPathsWithOptions` implementations.
 * Updates minimum supported SDK version to Flutter 3.32/Dart 3.8.
 
 ## 0.5.2+2

packages/file_selector/file_selector_android/example/pubspec.yaml

@@ -14,7 +14,7 @@ dependencies:
     # The example app is bundled with the plugin so we use a path dependency on
     # the parent directory to use the current plugin's version.
     path: ../
-  file_selector_platform_interface: ^2.5.0
+  file_selector_platform_interface: ^2.7.0
   flutter:
     sdk: flutter
   flutter_driver:

packages/file_selector/file_selector_android/lib/src/file_selector_android.dart

@@ -53,7 +53,14 @@ class FileSelectorAndroid extends FileSelectorPlatform {
     String? initialDirectory,
     String? confirmButtonText,
   }) async {
-    return _api.getDirectoryPath(initialDirectory);
+    return getDirectoryPathWithOptions(
+      FileDialogOptions(initialDirectory: initialDirectory),
+    );
+  }
+
+  @override
+  Future<String?> getDirectoryPathWithOptions(FileDialogOptions options) async {
+    return _api.getDirectoryPath(options.initialDirectory);
   }
 
   XFile _xFileFromFileResponse(FileResponse file) {

packages/file_selector/file_selector_android/pubspec.yaml

@@ -2,7 +2,7 @@ name: file_selector_android
 description: Android implementation of the file_selector package.
 repository: https://github.com/flutter/packages/tree/main/packages/file_selector/file_selector_android
 issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+file_selector%22
-version: 0.5.2+2
+version: 0.5.3
 
 environment:
   sdk: ^3.9.0
@@ -18,7 +18,7 @@ flutter:
         pluginClass: FileSelectorAndroidPlugin
 
 dependencies:
-  file_selector_platform_interface: ^2.5.0
+  file_selector_platform_interface: ^2.7.0
   flutter:
     sdk: flutter
   plugin_platform_interface: ^2.1.7

packages/file_selector/file_selector_linux/CHANGELOG.md

@@ -1,5 +1,6 @@
-## NEXT
+## 0.9.4
 
+* Adds `getDirectoryPathWithOptions` and `getDirectoryPathsWithOptions` implementations.
 * Updates minimum supported SDK version to Flutter 3.32/Dart 3.8.
 
 ## 0.9.3+2

packages/file_selector/file_selector_linux/example/pubspec.yaml

@@ -10,7 +10,7 @@ environment:
 dependencies:
   file_selector_linux:
     path: ../
-  file_selector_platform_interface: ^2.6.0
+  file_selector_platform_interface: ^2.7.0
   flutter:
     sdk: flutter
 

packages/file_selector/file_selector_linux/lib/file_selector_linux.dart

@@ -94,6 +94,7 @@ class FileSelectorLinux extends FileSelectorPlatform {
         currentFolderPath: options.initialDirectory,
         currentName: options.suggestedName,
         acceptButtonLabel: options.confirmButtonText,
+        createFolders: options.canCreateDirectories,
       ),
     );
     return paths.isEmpty ? null : FileSaveLocation(paths.first);
@@ -104,11 +105,22 @@ class FileSelectorLinux extends FileSelectorPlatform {
     String? initialDirectory,
     String? confirmButtonText,
   }) async {
+    return getDirectoryPathWithOptions(
+      FileDialogOptions(
+        initialDirectory: initialDirectory,
+        confirmButtonText: confirmButtonText,
+      ),
+    );
+  }
+
+  @override
+  Future<String?> getDirectoryPathWithOptions(FileDialogOptions options) async {
     final List<String> paths = await _hostApi.showFileChooser(
       PlatformFileChooserActionType.chooseDirectory,
       PlatformFileChooserOptions(
-        currentFolderPath: initialDirectory,
-        acceptButtonLabel: confirmButtonText,
+        currentFolderPath: options.initialDirectory,
+        acceptButtonLabel: options.confirmButtonText,
+        createFolders: options.canCreateDirectories,
         selectMultiple: false,
       ),
     );
@@ -120,11 +132,24 @@ class FileSelectorLinux extends FileSelectorPlatform {
     String? initialDirectory,
     String? confirmButtonText,
   }) async {
+    return getDirectoryPathsWithOptions(
+      FileDialogOptions(
+        initialDirectory: initialDirectory,
+        confirmButtonText: confirmButtonText,
+      ),
+    );
+  }
+
+  @override
+  Future<List<String>> getDirectoryPathsWithOptions(
+    FileDialogOptions options,
+  ) async {
     return _hostApi.showFileChooser(
       PlatformFileChooserActionType.chooseDirectory,
       PlatformFileChooserOptions(
-        currentFolderPath: initialDirectory,
-        acceptButtonLabel: confirmButtonText,
+        currentFolderPath: options.initialDirectory,
+        acceptButtonLabel: options.confirmButtonText,
+        createFolders: options.canCreateDirectories,
         selectMultiple: true,
       ),
     );

packages/file_selector/file_selector_linux/lib/src/messages.g.dart

@@ -1,7 +1,7 @@
 // Copyright 2013 The Flutter Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-// Autogenerated from Pigeon (v22.6.2), do not edit directly.
+// Autogenerated from Pigeon (v22.7.4), do not edit directly.
 // See also: https://pub.dev/packages/pigeon
 // ignore_for_file: public_member_api_docs, non_constant_identifier_names, avoid_as, unused_import, unnecessary_parenthesis, prefer_null_aware_operators, omit_local_variable_types, unused_shown_name, unnecessary_import, no_leading_underscores_for_local_identifiers
 
@@ -59,6 +59,7 @@ class PlatformFileChooserOptions {
     this.currentName,
     this.acceptButtonLabel,
     this.selectMultiple,
+    this.createFolders,
   });
 
   List<PlatformTypeGroup>? allowedFileTypes;
@@ -74,13 +75,19 @@ class PlatformFileChooserOptions {
   /// Nullable because it does not apply to the "save" action.
   bool? selectMultiple;
 
+  /// Whether to allow new folders creation.
+  ///
+  /// Nullable because it does not apply to the "open" action.
+  bool? createFolders;
+
   Object encode() {
     return <Object?>[
       allowedFileTypes,
       currentFolderPath,
       currentName,
       acceptButtonLabel,
       selectMultiple,
+      createFolders,
     ];
   }
 
@@ -93,6 +100,7 @@ class PlatformFileChooserOptions {
       currentName: result[2] as String?,
       acceptButtonLabel: result[3] as String?,
       selectMultiple: result[4] as bool?,
+      createFolders: result[5] as bool?,
     );
   }
 }

packages/file_selector/file_selector_linux/linux/file_selector_plugin.cc

@@ -94,6 +94,13 @@ static GtkFileChooserNative* create_dialog(
     }
   }
 
+  const gboolean* create_folders =
+      ffs_platform_file_chooser_options_get_create_folders(options);
+  if (create_folders != nullptr) {
+    gtk_file_chooser_set_create_folders(GTK_FILE_CHOOSER(dialog),
+                                        *create_folders);
+  }
+
   return GTK_FILE_CHOOSER_NATIVE(g_object_ref(dialog));
 }
 

packages/file_selector/file_selector_linux/linux/messages.g.cc

@@ -1,7 +1,7 @@
 // Copyright 2013 The Flutter Authors
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
-// Autogenerated from Pigeon (v22.6.2), do not edit directly.
+// Autogenerated from Pigeon (v22.7.4), do not edit directly.
 // See also: https://pub.dev/packages/pigeon
 
 #include "messages.g.h"
@@ -84,6 +84,7 @@ struct _FfsPlatformFileChooserOptions {
   gchar* current_name;
   gchar* accept_button_label;
   gboolean* select_multiple;
+  gboolean* create_folders;
 };
 
 G_DEFINE_TYPE(FfsPlatformFileChooserOptions, ffs_platform_file_chooser_options,
@@ -97,6 +98,7 @@ static void ffs_platform_file_chooser_options_dispose(GObject* object) {
   g_clear_pointer(&self->current_name, g_free);
   g_clear_pointer(&self->accept_button_label, g_free);
   g_clear_pointer(&self->select_multiple, g_free);
+  g_clear_pointer(&self->create_folders, g_free);
   G_OBJECT_CLASS(ffs_platform_file_chooser_options_parent_class)
       ->dispose(object);
 }
@@ -112,7 +114,7 @@ static void ffs_platform_file_chooser_options_class_init(
 FfsPlatformFileChooserOptions* ffs_platform_file_chooser_options_new(
     FlValue* allowed_file_types, const gchar* current_folder_path,
     const gchar* current_name, const gchar* accept_button_label,
-    gboolean* select_multiple) {
+    gboolean* select_multiple, gboolean* create_folders) {
   FfsPlatformFileChooserOptions* self = FFS_PLATFORM_FILE_CHOOSER_OPTIONS(
       g_object_new(ffs_platform_file_chooser_options_get_type(), nullptr));
   if (allowed_file_types != nullptr) {
@@ -141,6 +143,12 @@ FfsPlatformFileChooserOptions* ffs_platform_file_chooser_options_new(
   } else {
     self->select_multiple = nullptr;
   }
+  if (create_folders != nullptr) {
+    self->create_folders = static_cast<gboolean*>(malloc(sizeof(gboolean)));
+    *self->create_folders = *create_folders;
+  } else {
+    self->create_folders = nullptr;
+  }
   return self;
 }
 
@@ -174,6 +182,12 @@ gboolean* ffs_platform_file_chooser_options_get_select_multiple(
   return self->select_multiple;
 }
 
+gboolean* ffs_platform_file_chooser_options_get_create_folders(
+    FfsPlatformFileChooserOptions* self) {
+  g_return_val_if_fail(FFS_IS_PLATFORM_FILE_CHOOSER_OPTIONS(self), nullptr);
+  return self->create_folders;
+}
+
 static FlValue* ffs_platform_file_chooser_options_to_list(
     FfsPlatformFileChooserOptions* self) {
   FlValue* values = fl_value_new_list();
@@ -194,6 +208,9 @@ static FlValue* ffs_platform_file_chooser_options_to_list(
   fl_value_append_take(values, self->select_multiple != nullptr
                                    ? fl_value_new_bool(*self->select_multiple)
                                    : fl_value_new_null());
+  fl_value_append_take(values, self->create_folders != nullptr
+                                   ? fl_value_new_bool(*self->create_folders)
+                                   : fl_value_new_null());
   return values;
 }
 
@@ -226,9 +243,16 @@ ffs_platform_file_chooser_options_new_from_list(FlValue* values) {
     select_multiple_value = fl_value_get_bool(value4);
     select_multiple = &select_multiple_value;
   }
+  FlValue* value5 = fl_value_get_list_value(values, 5);
+  gboolean* create_folders = nullptr;
+  gboolean create_folders_value;
+  if (fl_value_get_type(value5) != FL_VALUE_TYPE_NULL) {
+    create_folders_value = fl_value_get_bool(value5);
+    create_folders = &create_folders_value;
+  }
   return ffs_platform_file_chooser_options_new(
       allowed_file_types, current_folder_path, current_name,
-      accept_button_label, select_multiple);
+      accept_button_label, select_multiple, create_folders);
 }
 
 struct _FfsMessageCodec {