Skip to content

[DisplayList] Use internal conversion for opacity->alpha #165349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2025
Merged

[DisplayList] Use internal conversion for opacity->alpha #165349

merged 1 commit into from
Mar 18, 2025

Conversation

flar
Copy link
Contributor

@flar flar commented Mar 17, 2025

Removing an unnecessary dependence on an external library for doing opacity->alpha conversions in DlPaint.

@flar flar marked this pull request as ready for review March 17, 2025 22:15
@github-actions github-actions bot added the engine flutter/engine repository. See also e: labels. label Mar 17, 2025
@flar
Copy link
Contributor Author

flar commented Mar 17, 2025 •
edited
Loading

This change could have been combined with other refactors, but since this line of code is used by OpacityLayers, there is a real potential to cause a large number of off-by-1 diffs in goldens.

jonahwilliams
jonahwilliams approved these changes Mar 18, 2025
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar flar added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
@auto-submit auto-submit bot added this pull request to the merge queue Mar 18, 2025
Merged via the queue into flutter:master with commit c5d4edf Mar 18, 2025
170 checks passed
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 18, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
6a937f2 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 25, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
af7e134 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
c0a3340 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
8ab7b82 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
ee38b9d 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
2d5cecf 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
0d30f48 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
bed0039 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
afe57e3 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 26, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
e278e88 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
b221c5a 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
413baf4 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
3420040 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
a27b0d2 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
166dcec 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 27, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
5e71e96 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
cc057d9 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
c62aa57 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
b3d6cd7 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
233bd4b 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
ea22aab 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 29, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
5e7ab55 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
da91074 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 30, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
5a076cc 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
fd50cf7 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
eb85d18 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
a4a6939 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
1d4cb36 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
ee142e1 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
874fe3a 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 31, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
80de790 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
ee85b5a 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
746717b 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
ebe6311 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 1, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
7eea5c5 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
ef3866c 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
432ed9d 
…lutter/flutter#165349)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
c5d4edfe9 [DisplayList] Use internal conversion for opacity->alpha (f…
8ec06f2 
…lutter/flutter#165349)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
engine flutter/engine repository. See also e: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flar @jonahwilliams