Skip to content

Warn that integration tests are not run automatically #162626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 3, 2025
Merged

Warn that integration tests are not run automatically #162626

merged 2 commits into from
Feb 3, 2025

Conversation

reidbaker
Copy link
Contributor

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
  • All existing and new tests are passing.

@reidbaker reidbaker requested a review from matanlurey February 3, 2025 20:14
matanlurey
matanlurey approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@matanlurey matanlurey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than nothing.

@reidbaker reidbaker added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@reidbaker reidbaker added this pull request to the merge queue Feb 3, 2025
Merged via the queue into master with commit 53e7e99 Feb 3, 2025
151 of 152 checks passed
@reidbaker reidbaker deleted the reidbaker-integration-test-reademe-warning-2025-02-01 branch February 3, 2025 23:27
@flutter-dashboard flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Feb 3, 2025
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
b7a82a1 
…ter/flutter#162626)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
7525807 
…ter/flutter#162626)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
1939937 
…ter/flutter#162626)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 4, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 4, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
ea3a058 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
6b61c69 
…ter/flutter#162626)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
4590555 
…ter/flutter#162626)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 5, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
7fde086 
…ter/flutter#162626)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 5, 2025
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
f566e9c 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
cf0f4cc 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
3d42a43 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 6, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
448abc2 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
6dc8df7 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
db00907 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 7, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
62d46ec 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
ec50438 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
bab7e5a 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
a599cbe 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 9, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
d415529 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
2943811 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
a91cd87 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
94aa3b1 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
906517b 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 10, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
ec4ae0e 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
6296eaf 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
1a0d6ae 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
6f58e06 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
b1a5fc0 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
9d4b3ce 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
335d73e 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 20, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
b56d584 
…ter/flutter#162626)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2025
@engine-flutter-autoroll
53e7e99c5 Warn that integration tests are not run automatically (flut…
cae411c 
…ter/flutter#162626)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matanlurey matanlurey matanlurey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reidbaker @matanlurey