Update template/test compileSdk, targetSdk, ndk versions

[gmackall]

Updates compileSdk, targetSdk, and ndk versions (former 2 to latest, latter to the version of the ndk we are hosting on CIPD).

Summary of changes:

• Updates mentioned template values
• compileSdk 35 requires AGP 8.0+, so updated to 8.1 in many places.
• This also necessitated Gradle upgrades in most places
• This also necessitated moving the package xml attribute to the AGP namespace field in a couple places (test + template).
• Some tests use the output of flutter create but then use intentionally lower AGP versions. I downgraded the compileSdk in these tests.
• Stopped lockfile generation script from hitting the hello_world example because it uses .kts gradle files.
• One test needed some Gradle options we had already added to templates.

Pre-launch Checklist

• I read the Contributor Guide and followed the process outlined there for submitting PRs.
• I read the Tree Hygiene wiki page, which explains my responsibilities.
• I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
• I signed the CLA.
• I listed at least one issue that this PR fixes in the description above.
• I updated/added relevant documentation (doc comments with ///).
• I added new tests to check the change I am making, or this PR is test-exempt.
• I followed the breaking change policy and added Data Driven Fixes where supported.
• All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

[gmackall]

Looks like we are hitting https://issuetracker.google.com/issues/342522139. Will need to update all the tests to a newer AGP version.

Unfortunately the gradle/gradle lockfile generation script seems to be broken for the use case of generating the gradle files themselves at this point, so first step will be to fix that.

[camsim99]

Looks good! Left some questions I had

[camsim99]

Are you updating to these versions of Gradle and AGP (8.4, 8.1.0) in the tests because of https://docs.gradle.org/current/userguide/compatibility.html#android?

[gmackall]

I'm updating them because of b/342522139 - basically compileSdk 35 seems to require AGP 8.1.0+. The specific choice of Gradle 8.4 was arbitrary though.

[gmackall]

I also realized that because this changes the FlutterExtension, it would also impact existing apps, so I added a gradle error handler for this case and also added a test for it.

Example of the error message:

Execution failed for task ':app:processReleaseResources'.
> A failure occurred while executing com.android.build.gradle.internal.res.LinkApplicationAndroidResourcesTask$TaskAction
   > Android resource linking failed
     aapt2 E 08-19 15:13:02 78026 5943581 LoadedArsc.cpp:94] RES_TABLE_TYPE_TYPE entry offsets overlap actual entry data.
     aapt2 E 08-19 15:13:02 78026 5943581 ApkAssets.cpp:152] Failed to load resources table in APK '/Users/mackall/Library/Android/sdk/platforms/android-35/android.jar'.
     error: failed to load include path /Users/mackall/Library/Android/sdk/platforms/android-35/android.jar.

And example of the handled version:

┌─ Flutter Fix ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ [!] Using compileSdk 35 requires Android Gradle Plugin (AGP) 8.1.0 or higher.                                                              │
│ Please upgrade to a newer AGP version. The version of AGP that your project uses is likely defined in:                                     │
│ /Users/mackall/development/BugTesting/testFlutterPluginGradlePlugin/foobarfoo/android/settings.gradle,                                     │
│ in the 'plugins' closure.                                                                                                                  │
│ Alternatively, if you have a strong reason to avoid upgrading AGP, you can temporarily lower the compileSdk version in the following file: │
│ /Users/mackall/development/BugTesting/testFlutterPluginGradlePlugin/foobarfoo/android/app/build.gradle                                     │
└────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

[reidbaker]

This is probably not the right file for most users. This is only the right file since we started using the plugin way of importing FGP.
/Users/mackall/development/BugTesting/testFlutterPluginGradlePlugin/foobarfoo/android/settings.gradle
prior to that it would have been /Users/mackall/development/BugTesting/testFlutterPluginGradlePlugin/foobarfoo/android/build.gradle
See this example from flutter vlc https://github.com/solid-software/flutter_vlc_player/blob/master/flutter_vlc_player/android/build.gradle

[gmackall]

Hmm I agree it is the less likely one (hopefully not by much now?), but it is definitely the one we support the most. I can keep telling people both locations for now I suppose, though I feel that three file paths in the message makes it a bit lengthy/gross.

Do you have any sense of when we would stop providing both links in situations like these? A year from now?

[gmackall]

Example of how it looks now:

┌─ Flutter Fix ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│ [!] Using compileSdk 35 requires Android Gradle Plugin (AGP) 8.1.0 or higher.                                                         │
│  Please upgrade to a newer AGP version. The version of AGP that your project uses is likely defined in:                               │
│ /Users/mackall/development/BugTesting/testFlutterPluginGradlePlugin/foobarfoo/android/settings.gradle,                                │
│ in the 'plugins' closure.                                                                                                             │
│  Alternatively, if your project was created with an older version of the templates, it is likely                                      │
│ in the buildscript.dependencies closure of the top-level build.gradle:                                                                │
│ /Users/mackall/development/BugTesting/testFlutterPluginGradlePlugin/foobarfoo/android/build.gradle.                                   │
│                                                                                                                                       │
│  Finally, if you have a strong reason to avoid upgrading AGP, you can temporarily lower the compileSdk version in the following file: │
│ /Users/mackall/development/BugTesting/testFlutterPluginGradlePlugin/foobarfoo/android/app/build.gradle                                │
└───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┘

I added the new link, and also added spaces to the start of each separate item which hopefully makes it more readable?

[reidbaker]

Hmm I agree it is the less likely one (hopefully not by much now?), but it is definitely the one we support the most. I can keep telling people both locations for now I suppose, though I feel that three file paths in the message makes it a bit lengthy/gross.

Do you have any sense of when we would stop providing both links in situations like these? A year from now?

We would stop telling people about both when we have removed the ability to import FGP as a script. Maybe a year from now. Most people have not migrated, my gut say 90+ percent of people. I could do a pub example check if we wanted.

[auto-submit]

A reason for requesting a revert of flutter/flutter/152487 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

[gmackall]

Reason for revert: I forgot that I need to override the compileSdkVersion in the AGP 8.0 instance of this test