Skip to content

Add @hideConstantImplementations to icons files #128235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add @hideConstantImplementations to icons files #128235

wants to merge 1 commit into from

Conversation

guidezpl
Copy link
Member

@guidezpl guidezpl commented Jun 5, 2023

This will hide the implementation in API docs

dart-lang/dartdoc#2657

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard bot added f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Jun 5, 2023
@github-actions github-actions bot removed f: material design flutter/packages/flutter/material repository. f: cupertino flutter/packages/flutter/cupertino repository labels Jun 5, 2023
@guidezpl
Copy link
Member Author

guidezpl commented Jun 5, 2023

Blocked pending a new version of dartdoc, cc @jcollins-g

@guidezpl guidezpl mentioned this pull request Jun 7, 2023
Merged
8 tasks
@guidezpl guidezpl closed this Jun 7, 2023
@guidezpl guidezpl deleted the icons branch July 3, 2023 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@guidezpl