Skip to content

[packages] make-deps-path-based should include everything in a federated plugin #168538

Open
@stuartmorgan-g

Description

@stuartmorgan-g

Currently the tool logic for make-deps-path-based has logic that was intended to solve the issue of transitive dependencies by having foo/example get all the same overrides as foo. That's usually enough, but not always; in particular, cases where some unrelated plugin's example depends on foo, but the plugin itself doesn't, then the example gets only foo overridden but none of foo's sub-dependencies, which causes CI failures. See flutter/packages#9212 for an example.

The tool should have additional logic that anything depending on foo* gets all overrides in the foo* conceptual plugin group, to avoid missed cases.

(In general the changes to other packages aren't actually necessary at the stage where this causes problems, but having the tool generate partial changes that don't work just causes confusion.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Important issues not at the top of the work listc: contributor-productivityTeam-specific productivity, code health, technical debt.packageflutter/packages repository. See also p: labels.team-ecosystemOwned by Ecosystem teamtriaged-ecosystemTriaged by Ecosystem team

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions