Skip to content

Commit a77655f

Browse files
authored
Fix simplest cases of ActionUpdateThread (#7407)
Partially addresses #7330 These are classes where there's clearly no UI manipulations happening in `update` in either the direct classes or inheriting children.
1 parent d7d35e3 commit a77655f

File tree

4 files changed

+22
-4
lines changed

4 files changed

+22
-4
lines changed

flutter-idea/src/io/flutter/actions/FlutterBuildActionGroup.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,6 +138,11 @@ public void actionPerformed(@NotNull AnActionEvent event) {
138138
}
139139
}
140140
}
141+
142+
@Override
143+
public @NotNull ActionUpdateThread getActionUpdateThread() {
144+
return ActionUpdateThread.BGT;
145+
}
141146
}
142147

143148
public static class AAR extends FlutterBuildAction {

flutter-idea/src/io/flutter/actions/OpenInAppCodeAction.java

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
import com.intellij.execution.process.ProcessAdapter;
1212
import com.intellij.execution.process.ProcessEvent;
1313
import com.intellij.execution.process.ProcessOutputTypes;
14+
import com.intellij.openapi.actionSystem.ActionUpdateThread;
1415
import com.intellij.openapi.actionSystem.AnAction;
1516
import com.intellij.openapi.actionSystem.AnActionEvent;
1617
import com.intellij.openapi.actionSystem.Presentation;
@@ -73,6 +74,10 @@ public void update(@NotNull AnActionEvent event) {
7374
}
7475
}
7576

77+
@Override
78+
public @NotNull ActionUpdateThread getActionUpdateThread() {
79+
return ActionUpdateThread.BGT;
80+
}
7681
@Override
7782
public void actionPerformed(@NotNull AnActionEvent event) {
7883
final VirtualFile projectFile = findProjectFile(event);

flutter-idea/src/io/flutter/actions/OpenInXcodeAction.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,7 @@
1010
import com.intellij.execution.process.ColoredProcessHandler;
1111
import com.intellij.execution.process.ProcessAdapter;
1212
import com.intellij.execution.process.ProcessEvent;
13-
import com.intellij.openapi.actionSystem.AnAction;
14-
import com.intellij.openapi.actionSystem.AnActionEvent;
15-
import com.intellij.openapi.actionSystem.CommonDataKeys;
16-
import com.intellij.openapi.actionSystem.Presentation;
13+
import com.intellij.openapi.actionSystem.*;
1714
import com.intellij.openapi.project.Project;
1815
import com.intellij.openapi.project.ProjectUtil;
1916
import com.intellij.openapi.util.SystemInfo;
@@ -159,6 +156,11 @@ public void update(@NotNull AnActionEvent event) {
159156
}
160157
}
161158

159+
@Override
160+
public @NotNull ActionUpdateThread getActionUpdateThread() {
161+
return ActionUpdateThread.BGT;
162+
}
163+
162164
@Override
163165
public void actionPerformed(@NotNull AnActionEvent event) {
164166
final VirtualFile projectFile = findProjectFile(event);

flutter-idea/src/io/flutter/actions/RunFlutterAction.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import com.intellij.execution.configurations.RunConfiguration;
1414
import com.intellij.execution.runners.ExecutionEnvironment;
1515
import com.intellij.execution.runners.ExecutionEnvironmentBuilder;
16+
import com.intellij.openapi.actionSystem.ActionUpdateThread;
1617
import com.intellij.openapi.actionSystem.AnAction;
1718
import com.intellij.openapi.actionSystem.AnActionEvent;
1819
import com.intellij.openapi.project.Project;
@@ -126,6 +127,11 @@ private static boolean shouldEnable(@Nullable AnActionEvent e) {
126127
return config instanceof SdkRunConfig && LaunchState.getRunningAppProcess((SdkRunConfig)config) == null;
127128
}
128129

130+
@Override
131+
public @NotNull ActionUpdateThread getActionUpdateThread() {
132+
return ActionUpdateThread.BGT;
133+
}
134+
129135
@Nullable
130136
protected static String getSelectedRunConfig(@Nullable AnActionEvent e) {
131137
final RunnerAndConfigurationSettings settings = getRunConfigSettings(e);

0 commit comments

Comments
 (0)