This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Update web_ui and web_sdk min Dart SDK versions to 3.6 #54590
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some dart:js_interop APIs that are available since 3.6 have been annotated with "@SInCE('3.6')". Since web_ui uses these APIs, analysis fails since the minimum SDK version is not >= 3.6. Dart SDK change: https://dart-review.googlesource.com/c/sdk/+/380900
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/54590, due to - The status or check suite Linux linux_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
Hmm, it looks like the try bots aren't happy with this. It looks like they're using an older dev version instead, so this might be more involved than just updating the version constraints. I'll close this for now, revert the original CL, and then revisit. Thanks for the help! |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 16, 2024
This reverts commit 14cf3b4. Reason for revert: web_ui uses some of these APIs, but the pubspec SDK version is not >= 3.6. Therefore, Flutter analyze fails, which would then result in a broken roll. Updating the pubspec versions leads to try bot failures (flutter/engine#54590) so for now, revert. Original change's description: > [dart:js_interop] Add Since('3.6') annotations to new APIs > > Closes #56484 > > Change-Id: I9d3da568aafeccbb855892ea5c2ba647371170bc > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380900 > Reviewed-by: Kevin Moore <[email protected]> > Reviewed-by: Leaf Petersen <[email protected]> > Reviewed-by: Sigmund Cherem <[email protected]> > Commit-Queue: Srujan Gaddam <[email protected]> > Reviewed-by: Martin Kustermann <[email protected]> Change-Id: Idfb021c5744d83a8004259f9c8774945a2612efd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380967 Reviewed-by: Leaf Petersen <[email protected]> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Srujan Gaddam <[email protected]>
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Aug 20, 2024
This reverts commit 7600900. Reason for revert: flutter/engine#54626 has update the pubspecs for web_ui and web_sdk to include `3.6`. Original change's description: > Revert "[dart:js_interop] Add Since('3.6') annotations to new APIs" > > This reverts commit 14cf3b4. > > Reason for revert: web_ui uses some of these APIs, but the pubspec SDK version is not >= 3.6. Therefore, Flutter analyze fails, which would then result in a broken roll. Updating the pubspec versions leads to try bot failures (flutter/engine#54590) so for now, revert. > > Original change's description: > > [dart:js_interop] Add Since('3.6') annotations to new APIs > > > > Closes #56484 > > > > Change-Id: I9d3da568aafeccbb855892ea5c2ba647371170bc > > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380900 > > Reviewed-by: Kevin Moore <[email protected]> > > Reviewed-by: Leaf Petersen <[email protected]> > > Reviewed-by: Sigmund Cherem <[email protected]> > > Commit-Queue: Srujan Gaddam <[email protected]> > > Reviewed-by: Martin Kustermann <[email protected]> > > Change-Id: Idfb021c5744d83a8004259f9c8774945a2612efd > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/380967 > Reviewed-by: Leaf Petersen <[email protected]> > Bot-Commit: Rubber Stamper <[email protected]> > Commit-Queue: Srujan Gaddam <[email protected]> Change-Id: I5c37640e06456d270db2adfd70283456bde671ce Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/381308 Bot-Commit: Rubber Stamper <[email protected]> Reviewed-by: Kevin Moore <[email protected]> Commit-Queue: Srujan Gaddam <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some dart:js_interop APIs that are available since 3.6 have been annotated with
@Since('3.6'). Since web_ui uses these APIs, analysis fails since the minimum SDK version is not >= 3.6.Dart SDK change: https://dart-review.googlesource.com/c/sdk/+/380900