Make iOS embedding to send full uri for deeplinks #41992
Conversation
chunhtai
force-pushed
the
issues/100624-ios
branch
from
d9f53c6 to
ef2b186
Compare
| arguments:@{@"location" : @"/custom/route?query=test"}]); | ||
| OCMVerify([self.mockNavigationChannel | ||
| invokeMethod:@"pushRouteInformation" | ||
| arguments:@{@"location" : @"http://myApp/custom/route?query=test"}]); |
There was a problem hiding this comment.
Isn't it weird to be using the "http" protocol for this?
There was a problem hiding this comment.
An universal link is either a http or https protocol.
There was a problem hiding this comment.
This is the framework pr flutter/flutter#119968, it just surface whatever url that is sent here to the developer in RouteInformation.url
The goal is to let developer to be able to handle differently based on what uri to launch the app, for example they may want to block certain route if the app is launch from example.com but not when it is launch from another-example.com
|
Looks like @gaaclarke s question was answered. Can we land this please? |
chunhtai
added
the
autosubmit
…127139) flutter/engine@2c77c80...c7c679d 2023-05-18 [email protected] Make iOS embedding to send full uri for deeplinks (flutter/engine#41992) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…lutter#127139) flutter/engine@2c77c80...c7c679d 2023-05-18 [email protected] Make iOS embedding to send full uri for deeplinks (flutter/engine#41992) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
|
Is this supposed to solve the issue mentioned in flutter/flutter#100624 (which is unfortunately locked)? I experienced the same problem, but this doesn't seem to fix it. What URL will flutter receive when starting the app with "myapp://page/1", if the hostname is not set as described in flutter/flutter#100624? Thanks |
|
@astubenbord please use discord if you would like to discuss more. If you are using router API, |
|
Hi, My deeplink works fine on Android device. On iOS, it only opens the App, but not the routed page. I followed the configuration mentioned in https://docs.flutter.dev/cookbook/navigation/set-up-universal-links. I found a similar issue mentioned in another post . This post(Make iOS embedding to send full uri for deeplinks) seems to be resolving this matter. Do we need to do anything different with our code to incorporate the changes? Could you advise on this? Many thanks |
related flutter/flutter#100624
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.