This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[ios_platform_view] MaskView pool to reuse maskViews." #39608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2023 17:21
…skViews. (flutter#38989)" (flutter#39490)" (flutter#39498)" This reverts commit 4270d74.
cyanglaz
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Feb 14, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 14, 2023
…120664) * 3b5c47d4d Revert "[ios_platform_view] MaskView pool to reuse maskViews." (flutter/engine#39608) * 170a4a31e Roll Skia from f27efe15433d to 38e363bbf0e4 (8 revisions) (flutter/engine#39611) * 632b5985a Roll Fuchsia Mac SDK from 6hbPQq6ED0PkuQiKM... to OeUljRQOmJwgDhNOo... (flutter/engine#39610) * 6a3aaefc0 Roll Fuchsia Linux SDK from 5b_BYTPWG1E7qx1I8... to mWwKhmxRlXNJATVmu... (flutter/engine#39613) * 17ab09d38 Remove bringup from builds. (flutter/engine#39605)
0xZOne
pushed a commit
to 0xZOne/engine
that referenced
this pull request
Feb 20, 2023
…er#39608) * Revert "Revert "Revert "[ios_platform_view] MaskView pool to reuse maskViews. (flutter#38989)" (flutter#39490)" (flutter#39498)" This reverts commit 4270d74. * fix build error
cyanglaz
pushed a commit
to cyanglaz/engine
that referenced
this pull request
Mar 20, 2023
flutter#39608)" This reverts commit 3b5c47d.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #39498
The original PR is breaking a customer. No issue created since I haven’t been able to repro. Will follow up with a Githu issue and updated re-land with the issue fixed.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.