This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add avoid_cache field to EmbedderRenderTarget to allow RenderTargets to avoid the cache #22742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
RichardJCai
force-pushed
the
avoid_render_cache
branch
from
a2f2b8f to
62f6268
Compare
…to bypass the cache
RichardJCai
force-pushed
the
avoid_render_cache
branch
from
62f6268 to
e00e616
Compare
|
I don't think this is backwards compatible. Thinking of ways to address this. |
|
closing per offline discussion. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on #22643
Approach described here #22643 (comment)
Created avoid_cache field to EmbedderRenderTarget.
CreateBackingStore takes a pointer to a bool which is modified to true if the backing store should not be cached.