Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit fccb9b6

Browse files
author
Chris Yang
authored
Remove Thread merging logic in DiscardLayerTreeOnResize test (#30803)
1 parent b74520b commit fccb9b6

File tree

1 file changed

+4
-28
lines changed

1 file changed

+4
-28
lines changed

shell/common/shell_unittests.cc

Lines changed: 4 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -2310,30 +2310,13 @@ TEST_F(ShellTest, DiscardLayerTreeOnResize) {
23102310
SkISize expected_size = SkISize::Make(400, 200);
23112311

23122312
fml::AutoResetWaitableEvent end_frame_latch;
2313-
std::shared_ptr<ShellTestExternalViewEmbedder> external_view_embedder;
2314-
fml::RefPtr<fml::RasterThreadMerger> raster_thread_merger_ref;
23152313
auto end_frame_callback =
23162314
[&](bool should_merge_thread,
23172315
fml::RefPtr<fml::RasterThreadMerger> raster_thread_merger) {
2318-
if (!raster_thread_merger_ref) {
2319-
raster_thread_merger_ref = raster_thread_merger;
2320-
}
2321-
if (should_merge_thread) {
2322-
// TODO(cyanglaz): This test used external_view_embedder so we need to
2323-
// merge the threads here. However, the scenario it is testing is
2324-
// unrelated to platform views. We should consider to update this test
2325-
// so it doesn't require external_view_embedder.
2326-
// https://github.com/flutter/flutter/issues/69895
2327-
raster_thread_merger->MergeWithLease(10);
2328-
external_view_embedder->UpdatePostPrerollResult(
2329-
PostPrerollResult::kSuccess);
2330-
}
23312316
end_frame_latch.Signal();
23322317
};
2333-
2334-
external_view_embedder = std::make_shared<ShellTestExternalViewEmbedder>(
2335-
std::move(end_frame_callback), PostPrerollResult::kResubmitFrame, true);
2336-
2318+
auto external_view_embedder = std::make_shared<ShellTestExternalViewEmbedder>(
2319+
std::move(end_frame_callback), PostPrerollResult::kSuccess, false);
23372320
std::unique_ptr<Shell> shell = CreateShell(
23382321
settings, GetTaskRunnersForFixture(), false, external_view_embedder);
23392322

@@ -2355,21 +2338,14 @@ TEST_F(ShellTest, DiscardLayerTreeOnResize) {
23552338

23562339
PumpOneFrame(shell.get(), static_cast<double>(wrong_size.width()),
23572340
static_cast<double>(wrong_size.height()));
2358-
23592341
end_frame_latch.Wait();
2360-
2342+
// Wrong size, no frames are submitted.
23612343
ASSERT_EQ(0, external_view_embedder->GetSubmittedFrameCount());
23622344

2363-
// Threads will be merged at the end of this frame.
23642345
PumpOneFrame(shell.get(), static_cast<double>(expected_size.width()),
23652346
static_cast<double>(expected_size.height()));
2366-
2367-
end_frame_latch.Wait();
2368-
ASSERT_TRUE(raster_thread_merger_ref->IsMerged());
2369-
23702347
end_frame_latch.Wait();
2371-
// 2 frames are submitted because `kResubmitFrame`, but only the 2nd frame
2372-
// should be submitted with `external_view_embedder`, hence the below check.
2348+
// Expected size, 1 frame submitted.
23732349
ASSERT_EQ(1, external_view_embedder->GetSubmittedFrameCount());
23742350
ASSERT_EQ(expected_size, external_view_embedder->GetLastSubmittedFrameSize());
23752351

0 commit comments

Comments
 (0)