Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit fbef328

Browse files
authored
Updated todo with github issue link (#41517)
followup from #41490 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [ ] I listed at least one issue that this PR fixes in the description above. - [ ] I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat
1 parent 7c05f2d commit fbef328

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

impeller/renderer/backend/vulkan/command_pool_vk.cc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@ namespace impeller {
1616

1717
using CommandPoolMap = std::map<uint64_t, std::shared_ptr<CommandPoolVK>>;
1818

19-
// TODO(tbd): This is storing tons of CommandPoolVK's in the test runner since
20-
// many contexts are created on the same thread. We need to come up
21-
// with a different way to clean these up.
19+
// TODO(https://github.com/flutter/flutter/issues/125571): This is storing tons
20+
// of CommandPoolVK's in the test runner since many contexts are created on the
21+
// same thread. We need to come up with a different way to clean these up.
2222
FML_THREAD_LOCAL fml::ThreadLocalUniquePtr<CommandPoolMap> tls_command_pool;
2323

2424
static Mutex g_all_pools_mutex;

0 commit comments

Comments
 (0)