Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit ad19499

Browse files
mspangCommit Bot
authored andcommitted
Disable broken tests on Fuchsia
This disables tests that do not work on Fuchsia. Most of them are related to cube maps which currently crash inside the intel driver. BUG=angleproject:2475, angleproject:3145, angleproject:3081 TEST=angle_end2end_tests on Fuchsia Change-Id: Ifc0be390c6d5c43a756e1afb6ced9e3bd5b6986e Reviewed-on: https://chromium-review.googlesource.com/c/1446497 Commit-Queue: Michael Spang <[email protected]> Reviewed-by: Geoff Lang <[email protected]>
1 parent 991d1cf commit ad19499

File tree

6 files changed

+29
-2
lines changed

6 files changed

+29
-2
lines changed

src/tests/gl_tests/ClearTest.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ TEST_P(ClearTest, Depth16Scissored)
364364
{
365365
// Crashes on NVIDIA and Android in FramebufferVk::clearWithClearAttachments.
366366
// http://anglebug.com/3081
367-
ANGLE_SKIP_TEST_IF(IsNVIDIA() || IsAndroid());
367+
ANGLE_SKIP_TEST_IF(IsNVIDIA() || IsAndroid() || IsFuchsia());
368368

369369
GLRenderbuffer renderbuffer;
370370
glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);
@@ -396,7 +396,7 @@ TEST_P(ClearTest, Stencil8Scissored)
396396
{
397397
// Crashes on NVIDIA and Android in FramebufferVk::clearWithClearAttachments.
398398
// http://anglebug.com/3081
399-
ANGLE_SKIP_TEST_IF(IsNVIDIA() || IsAndroid());
399+
ANGLE_SKIP_TEST_IF(IsNVIDIA() || IsAndroid() || IsFuchsia());
400400

401401
GLRenderbuffer renderbuffer;
402402
glBindRenderbuffer(GL_RENDERBUFFER, renderbuffer);

src/tests/gl_tests/CopyTextureTest.cpp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2715,6 +2715,9 @@ TEST_P(CopyTextureTest, CubeMapTarget)
27152715
// http://anglebug.com/1932
27162716
ANGLE_SKIP_TEST_IF(IsOSX() && IsIntel() && IsDesktopOpenGL());
27172717

2718+
// http://anglebug.com/3145
2719+
ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
2720+
27182721
GLColor pixels[7] = {
27192722
GLColor(10u, 13u, 16u, 19u), GLColor(20u, 23u, 26u, 29u), GLColor(30u, 33u, 36u, 39u),
27202723
GLColor(40u, 43u, 46u, 49u), GLColor(50u, 53u, 56u, 59u), GLColor(60u, 63u, 66u, 69u),
@@ -2776,6 +2779,9 @@ TEST_P(CopyTextureTest, CubeMapTargetBGRA)
27762779
return;
27772780
}
27782781

2782+
// http://anglebug.com/3145
2783+
ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
2784+
27792785
GLColor pixels[7] = {
27802786
GLColor(10u, 13u, 16u, 19u), GLColor(20u, 23u, 26u, 29u), GLColor(30u, 33u, 36u, 39u),
27812787
GLColor(40u, 43u, 46u, 49u), GLColor(50u, 53u, 56u, 59u), GLColor(60u, 63u, 66u, 69u),
@@ -2837,6 +2843,9 @@ TEST_P(CopyTextureTest, CubeMapTargetRGB)
28372843
// http://anglebug.com/1932
28382844
ANGLE_SKIP_TEST_IF(IsOSX() && IsIntel() && IsDesktopOpenGL());
28392845

2846+
// http://anglebug.com/3145
2847+
ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
2848+
28402849
constexpr uint8_t pixels[16 * 7] = {
28412850
0u, 3u, 6u, 10u, 13u, 16u, 0, 0, 20u, 23u, 26u, 30u, 33u, 36u, 0, 0, // 2x2
28422851
40u, 43u, 46u, 50u, 53u, 56u, 0, 0, 60u, 63u, 66u, 70u, 73u, 76u, 0, 0, // 2x2

src/tests/gl_tests/CubeMapTextureTest.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,9 @@ TEST_P(CubeMapTextureTest, RenderToFacesConsecutively)
6363
// TODO: Diagnose and fix. http://anglebug.com/2954
6464
ANGLE_SKIP_TEST_IF(IsVulkan() && IsIntel() && IsWindows());
6565

66+
// http://anglebug.com/3145
67+
ANGLE_SKIP_TEST_IF(IsVulkan() && IsIntel() && IsFuchsia());
68+
6669
const GLfloat faceColors[] = {
6770
1.0f, 0.0f, 0.0f, 1.0f, 0.0f, 1.0f, 0.0f, 1.0f, 0.0f, 0.0f, 1.0f, 1.0f,
6871
1.0f, 1.0f, 0.0f, 1.0f, 1.0f, 0.0f, 1.0f, 1.0f, 0.0f, 1.0f, 1.0f, 1.0f,

src/tests/gl_tests/FramebufferTest.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,9 @@ TEST_P(FramebufferFormatsTest, RenderbufferMultisample_STENCIL_INDEX8)
272272
// Test that binding an incomplete cube map is rejected by ANGLE.
273273
TEST_P(FramebufferFormatsTest, IncompleteCubeMap)
274274
{
275+
// http://anglebug.com/3145
276+
ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
277+
275278
// First make a complete CubeMap.
276279
glGenTextures(1, &mTexture);
277280
glBindTexture(GL_TEXTURE_CUBE_MAP, mTexture);

src/tests/gl_tests/MipmapTest.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -781,6 +781,9 @@ TEST_P(MipmapTest, TextureCubeGeneralLevelZero)
781781
// TODO(jmadill): Diagnose and fix. http://anglebug.com/2817
782782
ANGLE_SKIP_TEST_IF(IsVulkan() && IsAndroid());
783783

784+
// http://anglebug.com/3145
785+
ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
786+
784787
glBindTexture(GL_TEXTURE_CUBE_MAP, mTextureCube);
785788

786789
// Draw. Since the negative-Y face's is blue, this should be blue.
@@ -820,6 +823,9 @@ TEST_P(MipmapTest, TextureCubeGeneralLevelZero)
820823
// This test ensures that rendering to level-zero of a TextureCube works as expected.
821824
TEST_P(MipmapTest, TextureCubeRenderToLevelZero)
822825
{
826+
// http://anglebug.com/3145
827+
ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
828+
823829
glBindTexture(GL_TEXTURE_CUBE_MAP, mTextureCube);
824830

825831
// Draw. Since the negative-Y face's is blue, this should be blue.

src/tests/gl_tests/TextureTest.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1349,6 +1349,9 @@ TEST_P(Texture2DTestWithDrawScale, MipmapsTwice)
13491349
// https://code.google.com/p/angleproject/issues/detail?id=849
13501350
TEST_P(TextureCubeTest, CubeMapFBO)
13511351
{
1352+
// http://anglebug.com/3145
1353+
ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
1354+
13521355
GLFramebuffer fbo;
13531356
glBindFramebuffer(GL_FRAMEBUFFER, fbo);
13541357

@@ -1391,6 +1394,9 @@ TEST_P(TextureCubeTest, CubeMapFBOScissoredClear)
13911394
// TODO(jie.a.chen): Diagnose and fix. http://anglebug.com/2822
13921395
ANGLE_SKIP_TEST_IF(IsVulkan() && IsIntel() && IsWindows());
13931396

1397+
// http://anglebug.com/3145
1398+
ANGLE_SKIP_TEST_IF(IsFuchsia() && IsIntel() && IsVulkan());
1399+
13941400
constexpr size_t kSize = 16;
13951401

13961402
GLFramebuffer fbo;

0 commit comments

Comments
 (0)