Address comments, fix playstoredynamicfeaturemanager:

Author: GaryQian

runtime/dart_isolate.cc

@@ -320,7 +320,7 @@ bool DartIsolate::Initialize(Dart_Isolate dart_isolate) {
     return false;
   }
 
-  Dart_SetDeferredLoadHandler(OnDartLoadLibrary);
+  tonic::LogIfError(Dart_SetDeferredLoadHandler(OnDartLoadLibrary));
 
   if (!UpdateThreadPoolNames()) {
     return false;
@@ -340,8 +340,7 @@ bool DartIsolate::LoadLoadingUnit(intptr_t loading_unit_id,
   tonic::DartState::Scope scope(this);
   Dart_Handle result = Dart_DeferredLoadComplete(loading_unit_id, snapshot_data,
                                                  snapshot_instructions);
-  if (Dart_IsApiError(result)) {
-    FML_LOG(ERROR) << "LOADING FAILED " << loading_unit_id;
+  if (tonic::LogIfError(result)) {
     result =
         Dart_DeferredLoadCompleteError(loading_unit_id, Dart_GetError(result),
                                        /*transient*/ true);

shell/platform/android/io/flutter/embedding/engine/dynamicfeatures/PlayStoreDynamicFeatureManager.java

@@ -195,13 +195,13 @@ private String loadingUnitIdToModuleName(int loadingUnitId) {
 
   public void downloadDynamicFeature(int loadingUnitId, String moduleName) {
     String resolvedModuleName =
-        moduleName == null ? moduleName : loadingUnitIdToModuleName(loadingUnitId);
+        moduleName != null ? moduleName : loadingUnitIdToModuleName(loadingUnitId);
     if (resolvedModuleName == null) {
       Log.d(TAG, "Dynamic feature module name was null.");
       return;
     }
 
-    SplitInstallRequest request = SplitInstallRequest.newBuilder().addModule(moduleName).build();
+    SplitInstallRequest request = SplitInstallRequest.newBuilder().addModule(resolvedModuleName).build();
 
     splitInstallManager
         // Submits the request to install the module through the
@@ -212,7 +212,7 @@ public void downloadDynamicFeature(int loadingUnitId, String moduleName) {
         // install which is handled in FeatureInstallStateUpdatedListener.
         .addOnSuccessListener(
             sessionId -> {
-              this.sessionIdToName.put(sessionId, moduleName);
+              this.sessionIdToName.put(sessionId, resolvedModuleName);
               this.sessionIdToLoadingUnitId.put(sessionId, loadingUnitId);
             })
         .addOnFailureListener(