Moves impeller/golden_tests_harvester to tools/golden_tests_harvester (#50211)

The tool is not Impeller specific, so moving it to the `tools/`
directory.

Author: zanderso

ci/analyze.sh

@@ -48,7 +48,6 @@ echo ""
 
 "$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/ci"
 "$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/flutter_frontend_server"
-"$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/impeller/golden_tests_harvester"
 "$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/impeller/tessellator/dart"
 "$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/lib/gpu"
 "$DART" analyze --fatal-infos --fatal-warnings "$FLUTTER_DIR/lib/ui"

ci/licenses_golden/excluded_files

@@ -166,13 +166,6 @@
 ../../../flutter/impeller/geometry/size_unittests.cc
 ../../../flutter/impeller/geometry/trig_unittests.cc
 ../../../flutter/impeller/golden_tests/README.md
-../../../flutter/impeller/golden_tests_harvester/.dart_tool
-../../../flutter/impeller/golden_tests_harvester/.gitignore
-../../../flutter/impeller/golden_tests_harvester/README.md
-../../../flutter/impeller/golden_tests_harvester/analysis_options.yaml
-../../../flutter/impeller/golden_tests_harvester/pubspec.lock
-../../../flutter/impeller/golden_tests_harvester/pubspec.yaml
-../../../flutter/impeller/golden_tests_harvester/test
 ../../../flutter/impeller/image/README.md
 ../../../flutter/impeller/playground
 ../../../flutter/impeller/renderer/backend/gles/test

ci/licenses_golden/licenses_flutter

@@ -5327,9 +5327,6 @@ ORIGIN: ../../../flutter/impeller/golden_tests/vulkan_screenshotter.h + ../../..
 ORIGIN: ../../../flutter/impeller/golden_tests/vulkan_screenshotter.mm + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/golden_tests/working_directory.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/golden_tests/working_directory.h + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/impeller/golden_tests_harvester/bin/golden_tests_harvester.dart + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/impeller/golden_tests_harvester/lib/golden_tests_harvester.dart + ../../../flutter/LICENSE
-ORIGIN: ../../../flutter/impeller/golden_tests_harvester/lib/logger.dart + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/image/backends/skia/compressed_image_skia.cc + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/image/backends/skia/compressed_image_skia.h + ../../../flutter/LICENSE
 ORIGIN: ../../../flutter/impeller/image/compressed_image.cc + ../../../flutter/LICENSE
@@ -8185,9 +8182,6 @@ FILE: ../../../flutter/impeller/golden_tests/vulkan_screenshotter.h
 FILE: ../../../flutter/impeller/golden_tests/vulkan_screenshotter.mm
 FILE: ../../../flutter/impeller/golden_tests/working_directory.cc
 FILE: ../../../flutter/impeller/golden_tests/working_directory.h
-FILE: ../../../flutter/impeller/golden_tests_harvester/bin/golden_tests_harvester.dart
-FILE: ../../../flutter/impeller/golden_tests_harvester/lib/golden_tests_harvester.dart
-FILE: ../../../flutter/impeller/golden_tests_harvester/lib/logger.dart
 FILE: ../../../flutter/impeller/image/backends/skia/compressed_image_skia.cc
 FILE: ../../../flutter/impeller/image/backends/skia/compressed_image_skia.h
 FILE: ../../../flutter/impeller/image/compressed_image.cc

impeller/golden_tests/README.md

@@ -2,7 +2,7 @@
 
 This is the executable that will generate the golden image results that can then
 be sent to Skia Gold vial the
-[golden_tests_harvester]("../golden_tests_harvester").
+[golden_tests_harvester]("../../tools/golden_tests_harvester").
 
 Running these tests should happen from
 [//flutter/testing/run_tests.py](../../testing/run_tests.py). That will do all

testing/run_tests.py

@@ -1110,7 +1110,7 @@ def run_impeller_golden_tests(build_dir: str):
         'Cannot find the "impeller_golden_tests" executable in "%s". You may need to build it.'
         % (build_dir)
     )
-  harvester_path: Path = Path(SCRIPT_DIR).parent.joinpath('impeller').joinpath(
+  harvester_path: Path = Path(SCRIPT_DIR).parent.joinpath('tools').joinpath(
       'golden_tests_harvester'
   )
   with tempfile.TemporaryDirectory(prefix='impeller_golden') as temp_dir:

…peller/golden_tests_harvester/.gitignore tools/golden_tests_harvester/.gitignoreimpeller/golden_tests_harvester/.gitignore renamed to tools/golden_tests_harvester/.gitignore impeller/golden_tests_harvester/.gitignore renamed to tools/golden_tests_harvester/.gitignore

@@ -7,8 +7,8 @@ Reaps the output of impeller's golden image tests and sends it to Skia gold.
 ```sh
 cd $SRC
 ./out/host_debug_unopt_arm64/impeller_golden_tests --working_dir=~/Desktop/temp
-cd flutter/impeller/golden_tests_harvester
+cd flutter/tools/golden_tests_harvester
 dart run ./bin/golden_tests_harvester.dart ~/Desktop/temp
 ```
 
-See also [golden_tests](../golden_tests/).
+See also [golden_tests](../impeller/golden_tests/).