Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 78a9ecb

Browse files
committed
disable goldens on Firefox
1 parent 6315d7f commit 78a9ecb

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

lib/web_ui/test/canvaskit/canvas_golden_test.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,8 @@ void testMain() {
5858
expect(restoredPixels.buffer.asUint8List(), originalPixels.buffer.asUint8List());
5959
});
6060
// TODO: https://github.com/flutter/flutter/issues/60040
61-
}, skip: isIosSafari);
61+
// TODO: https://github.com/flutter/flutter/issues/71520
62+
}, skip: isIosSafari || isFirefox);
6263
}
6364

6465
void drawTestPicture(CkCanvas canvas) {

lib/web_ui/test/canvaskit/common.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,14 @@ import 'package:test/test.dart';
77
import 'package:ui/src/engine.dart';
88
import 'package:ui/ui.dart' as ui;
99

10-
/// Whether we are running on iOS Safari.
10+
/// Whether the current browser is Safari on iOS.
1111
// TODO: https://github.com/flutter/flutter/issues/60040
1212
bool get isIosSafari => browserEngine == BrowserEngine.webkit &&
1313
operatingSystem == OperatingSystem.iOs;
1414

15+
/// Whether the current browser is Firefox.
16+
bool get isFirefox => browserEngine == BrowserEngine.firefox;
17+
1518
/// Used in tests instead of [ProductionCollector] to control Skia object
1619
/// collection explicitly, and to prevent leaks across tests.
1720
///

0 commit comments

Comments
 (0)