Version 2.12.0-17.0.dev

Merge commit '89de1e82d9073d3f3a96145ad24940e8c311b493' into 'dev'

Author: Dart CI

DEPS

@@ -69,7 +69,7 @@ vars = {
 
   # Revisions of /third_party/* dependencies.
   "args_tag": "1.6.0",
-  "async_rev": "6d2de25f208b011d79d056115256d3840229723b",
+  "async_rev": "695b3ac280f107c84adf7488743abfdfaaeea68f",
   "bazel_worker_rev": "26680d5e249b249c7216ab2fed0ac8ed4ee285c5",
   "benchmark_harness_rev": "ec6b646f5443faa871e126ac1ba248c94ca06257",
   "boolean_selector_rev": "665e6921ab246569420376f827bff4585dff0b14",
@@ -101,7 +101,7 @@ vars = {
 "dart_style_tag": "1.3.9",  # Please see the note above before updating.
 
   "chromedriver_tag": "83.0.4103.39",
-  "dartdoc_rev" : "72c69f8659ce8823ce2dde9a4f758b0fa617ab5e",
+  "dartdoc_rev" : "6935dcd8f2d78cf1797e6365b4b71505e6579659",
   "ffi_rev": "a90bd424116fb6f416337db67425171f2dc4c98f",
   "fixnum_rev": "16d3890c6dc82ca629659da1934e412292508bba",
   "glob_rev": "e9f4e6b7ae8abe5071461cf8f47191bb19cf7ef6",
@@ -147,7 +147,7 @@ vars = {
   "source_maps_rev": "53eb92ccfe6e64924054f83038a534b959b12b3e",
   "source_span_rev": "cc7c4288a83f71ecef3414199947b52a8c112c65",
   "sse_tag": "e5cf68975e8e87171a3dc297577aa073454a91dc",
-  "stack_trace_tag": "45319bfd2a6da228d8c32b06e1da02ad199373c7",
+  "stack_trace_tag": "c9c867fa9d5b9c8a059e33d3efe759698aa49d60",
   "stagehand_tag": "v3.3.9",
   "stream_channel_tag": "d7251e61253ec389ee6e045ee1042311bced8f1d",
   "string_scanner_rev": "1b63e6e5db5933d7be0a45da6e1129fe00262734",

pkg/analyzer/lib/error/error.dart

@@ -535,6 +535,7 @@ const List<ErrorCode> errorCodeValues = [
   HintCode.NULL_AWARE_BEFORE_OPERATOR,
   HintCode.NULL_AWARE_IN_CONDITION,
   HintCode.NULL_AWARE_IN_LOGICAL_OPERATOR,
+  HintCode.NULL_CHECK_ALWAYS_FAILS,
   HintCode.NULLABLE_TYPE_IN_CATCH_CLAUSE,
   HintCode.OVERRIDE_EQUALS_BUT_NOT_HASH_CODE,
   HintCode.OVERRIDE_ON_NON_OVERRIDING_FIELD,

pkg/analyzer/lib/src/dart/error/hint_codes.dart

@@ -1434,6 +1434,15 @@ class HintCode extends AnalyzerErrorCode {
       "The value of the '?.' operator can be 'null', which isn't appropriate "
           "as an operand of a logical operator.");
 
+  /**
+   * This hint indicates that a null literal is null-checked with `!`, but null
+   * is never not null.
+   */
+  static const HintCode NULL_CHECK_ALWAYS_FAILS = HintCode(
+      'NULL_CHECK_ALWAYS_FAILS',
+      "This null-check will always throw an exception because the expression "
+          "will always evaluate to 'null'.");
+
   /**
    * No parameters.
    */

pkg/analyzer/lib/src/dart/resolver/prefixed_identifier_resolver.dart

@@ -32,10 +32,60 @@ class PrefixedIdentifierResolver {
       hasWrite: false,
     );
 
+    var element = result.readElement;
+
     var identifier = node.identifier;
-    identifier.staticElement = result.readElement;
+    identifier.staticElement = element;
+
+    if (element is ExtensionElement) {
+      _setExtensionIdentifierType(node);
+      return;
+    }
 
-    _resolve2(node);
+    if (identical(node.prefix.staticType, NeverTypeImpl.instance)) {
+      _recordStaticType(identifier, NeverTypeImpl.instance);
+      _recordStaticType(node, NeverTypeImpl.instance);
+      return;
+    }
+
+    DartType type = DynamicTypeImpl.instance;
+    if (element is ClassElement) {
+      if (_isExpressionIdentifier(node)) {
+        var type = _typeProvider.typeType;
+        node.staticType = type;
+        identifier.staticType = type;
+      }
+      return;
+    } else if (element is DynamicElementImpl) {
+      var type = _typeProvider.typeType;
+      node.staticType = type;
+      identifier.staticType = type;
+      return;
+    } else if (element is FunctionTypeAliasElement) {
+      if (node.parent is TypeName) {
+        // no type
+      } else {
+        var type = _typeProvider.typeType;
+        node.staticType = type;
+        identifier.staticType = type;
+      }
+      return;
+    } else if (element is MethodElement) {
+      type = element.type;
+    } else if (element is PropertyAccessorElement) {
+      type = _getTypeOfProperty(element);
+    } else if (element is ExecutableElement) {
+      type = element.type;
+    } else if (element is VariableElement) {
+      type = element.type;
+    } else if (result.functionTypeCallType != null) {
+      type = result.functionTypeCallType;
+    }
+
+    type = _inferenceHelper.inferTearOff(node, identifier, type);
+
+    _recordStaticType(identifier, type);
+    _recordStaticType(node, type);
   }
 
   /// Return the type that should be recorded for a node that resolved to the given accessor.
@@ -103,60 +153,6 @@ class PrefixedIdentifierResolver {
     _inferenceHelper.recordStaticType(expression, type);
   }
 
-  void _resolve2(PrefixedIdentifier node) {
-    SimpleIdentifier prefixedIdentifier = node.identifier;
-    Element staticElement = prefixedIdentifier.staticElement;
-
-    if (staticElement is ExtensionElement) {
-      _setExtensionIdentifierType(node);
-      return;
-    }
-
-    if (identical(node.prefix.staticType, NeverTypeImpl.instance)) {
-      _recordStaticType(prefixedIdentifier, NeverTypeImpl.instance);
-      _recordStaticType(node, NeverTypeImpl.instance);
-      return;
-    }
-
-    DartType staticType = DynamicTypeImpl.instance;
-    if (staticElement is ClassElement) {
-      if (_isExpressionIdentifier(node)) {
-        var type = _typeProvider.typeType;
-        node.staticType = type;
-        node.identifier.staticType = type;
-      }
-      return;
-    } else if (staticElement is DynamicElementImpl) {
-      var type = _typeProvider.typeType;
-      node.staticType = type;
-      node.identifier.staticType = type;
-      return;
-    } else if (staticElement is FunctionTypeAliasElement) {
-      if (node.parent is TypeName) {
-        // no type
-      } else {
-        var type = _typeProvider.typeType;
-        node.staticType = type;
-        node.identifier.staticType = type;
-      }
-      return;
-    } else if (staticElement is MethodElement) {
-      staticType = staticElement.type;
-    } else if (staticElement is PropertyAccessorElement) {
-      staticType = _getTypeOfProperty(staticElement);
-    } else if (staticElement is ExecutableElement) {
-      staticType = staticElement.type;
-    } else if (staticElement is VariableElement) {
-      staticType = staticElement.type;
-    }
-
-    staticType =
-        _inferenceHelper.inferTearOff(node, node.identifier, staticType);
-
-    _recordStaticType(prefixedIdentifier, staticType);
-    _recordStaticType(node, staticType);
-  }
-
   /// TODO(scheglov) this is duplicate
   void _setExtensionIdentifierType(Identifier node) {
     if (node is SimpleIdentifier && node.inDeclarationContext()) {

pkg/analyzer/lib/src/dart/resolver/property_element_resolver.dart

@@ -329,6 +329,12 @@ class PropertyElementResolver {
 
     var targetType = target.staticType;
 
+    if (targetType is FunctionType && propertyName.name == 'call') {
+      return PropertyElementResolverResult(
+        functionTypeCallType: targetType,
+      );
+    }
+
     if (targetType.isVoid) {
       _errorReporter.reportErrorForNode(
         CompileTimeErrorCode.USE_OF_VOID_RESULT,
@@ -693,6 +699,7 @@ class PropertyElementResolverResult {
   final Element readElementRecovery;
   final Element writeElementRequested;
   final Element writeElementRecovery;
+  final FunctionType functionTypeCallType;
 
   /// If [IndexExpression] is resolved, the context type of the index.
   /// Might be `null` if `[]` or `[]=` are not resolved or invalid.
@@ -704,6 +711,7 @@ class PropertyElementResolverResult {
     this.writeElementRequested,
     this.writeElementRecovery,
     this.indexContextType,
+    this.functionTypeCallType,
   });
 
   Element get readElement {

pkg/analyzer/lib/src/error/best_practices_verifier.dart

@@ -613,6 +613,9 @@ class BestPracticesVerifier extends RecursiveAstVisitor<void> {
   @override
   void visitPostfixExpression(PostfixExpression node) {
     _deprecatedVerifier.postfixExpression(node);
+    if (node.operand.staticType?.isDartCoreNull ?? false) {
+      _errorReporter.reportErrorForNode(HintCode.NULL_CHECK_ALWAYS_FAILS, node);
+    }
     super.visitPostfixExpression(node);
   }
 

pkg/analyzer/lib/src/generated/resolver.dart

@@ -1743,6 +1743,8 @@ class ResolverVisitor extends ScopedVisitor {
       type = element.type;
     } else if (element is PropertyAccessorElement && element.isGetter) {
       type = element.returnType;
+    } else if (result.functionTypeCallType != null) {
+      type = result.functionTypeCallType;
     } else {
       type = DynamicTypeImpl.instance;
     }

pkg/analyzer/test/src/dart/analysis/driver_resolution_test.dart

@@ -6218,7 +6218,7 @@ main(double computation(int p)) {
 
     SimpleIdentifier methodName = prefixed.identifier;
     expect(methodName.staticElement, isNull);
-    expect(methodName.staticType, typeProvider.dynamicType);
+    assertType(methodName.staticType, 'double Function(int)');
   }
 
   test_prefixedIdentifier_importPrefix_className() async {

pkg/analyzer/test/src/dart/resolution/postfix_expression_test.dart

@@ -614,11 +614,13 @@ void f(Map<String, int> a) {
   }
 
   test_nullCheck_null() async {
-    await assertNoErrorsInCode('''
+    await assertErrorsInCode('''
 void f(Null x) {
   x!;
 }
-''');
+''', [
+      error(HintCode.NULL_CHECK_ALWAYS_FAILS, 19, 2),
+    ]);
 
     assertType(findNode.postfix('x!'), 'Never');
   }

pkg/analyzer/test/src/dart/resolution/prefixed_identifier_test.dart

@@ -33,6 +33,20 @@ main() {
     );
   }
 
+  test_functionType_call_read() async {
+    await assertNoErrorsInCode('''
+void f(int Function(String) a) {
+  a.call;
+}
+''');
+
+    assertPrefixedIdentifier(
+      findNode.prefixed('.call;'),
+      element: null,
+      type: 'int Function(String)',
+    );
+  }
+
   test_implicitCall_tearOff() async {
     newFile('$testPackageLibPath/a.dart', content: r'''
 class A {