Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 53635ef

Browse files
author
Jonah Williams
authored
Revert "[Impeller] dont use concurrent runner to decode images on Android." (#43061)
Reverts #42944 This didn't improve any of the benchmarks, which I think at least disproves my theory on overloading. Lets go back to the prior strategy and look for improvements elsewhere.
1 parent 25d857c commit 53635ef

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

lib/ui/painting/image_decoder_impeller.cc

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -456,11 +456,7 @@ void ImageDecoderImpeller::Decode(fml::RefPtr<ImageDescriptor> descriptor,
456456
});
457457
};
458458

459-
#ifdef FML_OS_ANDROID
460-
runners_.GetIOTaskRunner()->PostTask(
461-
#else
462459
concurrent_task_runner_->PostTask(
463-
#endif
464460
[raw_descriptor, //
465461
context = context_.get(), //
466462
target_size = SkISize::Make(target_width, target_height), //
@@ -499,16 +495,12 @@ void ImageDecoderImpeller::Decode(fml::RefPtr<ImageDescriptor> descriptor,
499495
result(image, decode_error);
500496
}
501497
};
502-
// TODO(jonahwilliams):
503-
// https://github.com/flutter/flutter/issues/123058 Technically we
504-
// don't need to post tasks to the io runner, but without this
505-
// forced serialization we can end up overloading the GPU and/or
506-
// competing with raster workloads.
507-
#ifdef FML_OS_ANDROID
508-
upload_texture_and_invoke_result();
509-
#else
498+
// TODO(jonahwilliams):
499+
// https://github.com/flutter/flutter/issues/123058 Technically we
500+
// don't need to post tasks to the io runner, but without this
501+
// forced serialization we can end up overloading the GPU and/or
502+
// competing with raster workloads.
510503
io_runner->PostTask(upload_texture_and_invoke_result);
511-
#endif
512504
});
513505
}
514506

0 commit comments

Comments
 (0)