Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 37620e1

Browse files
author
jonahwilliams
committed
rename golden to see what gets generated.
1 parent ae00dad commit 37620e1

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

testing/scenario_app/android/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ or [platform views](https://docs.flutter.dev/platform-integration/android/platfo
7373
and as such, the tests in this package use golden screenshot file comparisons to
7474
verify the correctness of the engine's output.
7575

76-
For example, in [`ExternalTextureTests_testMediaSurface`](https://flutter-engine-gold.skia.org/search?corpus=flutter-engine&include_ignored=false&left_filter=name%3DExternalTextureTests_testMediaSurface&max_rgba=0&min_rgba=0&negative=true&not_at_head=false&positive=true&reference_image_required=false&right_filter=&sort=descending&untriaged=true), a [video](app/src/main/assets/sample.mp4) is converted to an external texture and displayed in a Flutter app. The test takes a screenshot of the app and compares it to a golden file:
76+
For example, in [`ExternalTextureTests_testMediaSurface2`](https://flutter-engine-gold.skia.org/search?corpus=flutter-engine&include_ignored=false&left_filter=name%3DExternalTextureTests_testMediaSurface2&max_rgba=0&min_rgba=0&negative=true&not_at_head=false&positive=true&reference_image_required=false&right_filter=&sort=descending&untriaged=true), a [video](app/src/main/assets/sample.mp4) is converted to an external texture and displayed in a Flutter app. The test takes a screenshot of the app and compares it to a golden file:
7777

78-
<img
78+
<img
7979
alt="Two pictures, the top one Flutter and the bottom Android"
8080
src="https://github.com/flutter/flutter/assets/168174/e2c34b88-d03d-4732-87e4-a86c97d006c5"
8181
width="300"

testing/scenario_app/android/app/src/androidTest/java/dev/flutter/scenariosui/ExternalTextureTests.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ public void testMediaSurface() throws Exception {
5151
intent.putExtra("scenario_name", "display_texture");
5252
intent.putExtra("surface_renderer", "media");
5353
ScreenshotUtil.capture(
54-
activityRule.launchActivity(intent), "ExternalTextureTests_testMediaSurface");
54+
activityRule.launchActivity(intent), "ExternalTextureTests_testMediaSurface2");
5555
}
5656

5757
@Test

testing/scenario_app/android/expected_golden_output.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ ExternalTextureTests_testCanvasSurface.png
33
ExternalTextureTests_testCroppedMediaSurface_bottomLeft.png
44
ExternalTextureTests_testCroppedMediaSurface_topRight.png
55
ExternalTextureTests_testCroppedRotatedMediaSurface_bottomLeft_90.png
6-
ExternalTextureTests_testMediaSurface.png
6+
ExternalTextureTests_testMediaSurface2.png
77
ExternalTextureTests_testRotatedMediaSurface_180.png
88
ExternalTextureTests_testRotatedMediaSurface_270.png
99
ExternalTextureTests_testRotatedMediaSurface_90.png

0 commit comments

Comments
 (0)