Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit 2fa3959

Browse files
author
nturgut
committed
fix the error made in the gaps
1 parent 5e96a5d commit 2fa3959

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

lib/web_ui/dev/browser_lock.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ ios-safari:
3434
# `heightOfHeader` is the number of pixels taken by the phone's header menu
3535
# and the browsers address bar.
3636
# TODO: https://github.com/flutter/flutter/issues/65672
37-
heightOfHeader: 283
37+
heightOfHeader: 189
3838
# `heightOfFooter` is the number of pixels taken by the phone's navigation
3939
# menu.
4040
heightOfFooter: 250
@@ -45,7 +45,7 @@ ios-safari:
4545
# phone screeen we enlarge or shrink the area by applying a linear
4646
# transformation by a scale_factor (a.k.a. we perform isotropic scaling).
4747
# This value will be differ depending on the phone.
48-
scaleFactor: 1.15
48+
scaleFactor: 1.145
4949

5050
## geckodriver is used for testing Firefox Browser. It works with multiple
5151
## Firefox Browser versions.

lib/web_ui/dev/test_runner.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,8 @@ class TestCommand extends Command<bool> with ArgUtils {
392392
// after solving the git issue faced on macOS and Windows bots:
393393
// TODO: https://github.com/flutter/flutter/issues/63710
394394
if ((isChrome && isLuci && io.Platform.isLinux) ||
395-
(isChrome && !isLuci) || (isSafariIOS && isLuci)) {
395+
((isChrome || isSafariIOS) && !isLuci) ||
396+
(isSafariIOS && isLuci)) {
396397
print('INFO: Also running the screenshot tests.');
397398
// Separate screenshot tests from unit-tests. Screenshot tests must run
398399
// one at a time. Otherwise, they will end up screenshotting each other.
-514 Bytes
Loading

0 commit comments

Comments
 (0)