Use a comma-separated args string for UWP (#26110)

cbracken · web-flow · commit 2c3c1dfb74f9 · 2021-05-12T17:11:11.000-07:00
UWP apps get a single arguments string on launch rather than an array. The current implementation splits that args string on commas. This updates the UWP launch args generation to match. Part of flutter/flutter#81756 Part of flutter/flutter#82085
diff --git a/shell/platform/windows/uwptool_main.cc b/shell/platform/windows/uwptool_main.cc
@@ -69,12 +69,12 @@ int main(int argc, char** argv) {
     // Get the package ID.
     std::string package_id = args[1];
 
-    // Concatenate the remaining args, space-separated.
+    // Concatenate the remaining args, comma-separated.
     std::ostringstream app_args;
     for (int i = 2; i < args.size(); ++i) {
       app_args << args[i];
       if (i < args.size() - 1) {
-        app_args << " ";
+        app_args << ",";
       }
     }
     int process_id = LaunchApp(flutter::Utf16FromUtf8(package_id),

Original file line number	Diff line number	Diff line change
`@@ -69,12 +69,12 @@ int main(int argc, char** argv) {`
`69`	`69`	`// Get the package ID.`
`70`	`70`	`std::string package_id = args[1];`
`71`	`71`
`72`		`- // Concatenate the remaining args, space-separated.`
	`72`	`+ // Concatenate the remaining args, comma-separated.`
`73`	`73`	`std::ostringstream app_args;`
`74`	`74`	`for (int i = 2; i < args.size(); ++i) {`
`75`	`75`	`app_args << args[i];`
`76`	`76`	`if (i < args.size() - 1) {`
`77`		`- app_args << " ";`
	`77`	`+ app_args << ",";`
`78`	`78`	`}`
`79`	`79`	`}`
`80`	`80`	`int process_id = LaunchApp(flutter::Utf16FromUtf8(package_id),`