Fix use-after-move

bdero · bdero · commit 1f8ad71ea8a8 · 2024-07-24T10:59:30.000-07:00
diff --git a/impeller/entity/entity_pass.cc b/impeller/entity/entity_pass.cc
@@ -107,9 +107,9 @@ void EntityPass::AddEntity(Entity entity) {
   if (entity.GetBlendMode() > Entity::kLastPipelineBlendMode) {
     advanced_blend_reads_from_pass_texture_ = true;
   }
-  elements_.emplace_back(std::move(entity));
-  draw_order_resolver_.AddElement(elements_.size() - 1,
+  draw_order_resolver_.AddElement(elements_.size(),
                                   entity.GetBlendMode() == BlendMode::kSource);
+  elements_.emplace_back(std::move(entity));
 }
 
 void EntityPass::PushClip(Entity entity) {

Original file line number	Diff line number	Diff line change
`@@ -107,9 +107,9 @@ void EntityPass::AddEntity(Entity entity) {`
`107`	`107`	`if (entity.GetBlendMode() > Entity::kLastPipelineBlendMode) {`
`108`	`108`	`advanced_blend_reads_from_pass_texture_ = true;`
`109`	`109`	`}`
`110`		`- elements_.emplace_back(std::move(entity));`
`111`		`- draw_order_resolver_.AddElement(elements_.size() - 1,`
	`110`	`+ draw_order_resolver_.AddElement(elements_.size(),`
`112`	`111`	`entity.GetBlendMode() == BlendMode::kSource);`
	`112`	`+ elements_.emplace_back(std::move(entity));`
`113`	`113`	`}`
`114`	`114`
`115`	`115`	`void EntityPass::PushClip(Entity entity) {`