Remove some logs

Author: gspencergoog

shell/platform/darwin/macos/framework/Source/FlutterEngine.mm

@@ -1086,7 +1086,6 @@ - (NSPasteboard*)pasteboard {
 - (void)setApplicationState:(flutter::AppLifecycleState)state {
   NSString* nextState =
       [[NSString alloc] initWithCString:flutter::AppLifecycleStateToString(state)];
-  NSLog(@"Moving to state %@", nextState);
   [self sendOnChannel:kFlutterLifecycleChannel
               message:[nextState dataUsingEncoding:NSUTF8StringEncoding]];
 }
@@ -1096,7 +1095,6 @@ - (void)setApplicationState:(flutter::AppLifecycleState)state {
  * notification.
  */
 - (void)handleWillBecomeActive:(NSNotification*)notification {
-  NSLog(@"Marked as active");
   _active = YES;
   if (!_visible) {
     [self setApplicationState:flutter::kAppLifecycleStateHidden];
@@ -1110,7 +1108,6 @@ - (void)handleWillBecomeActive:(NSNotification*)notification {
  * notification.
  */
 - (void)handleWillResignActive:(NSNotification*)notification {
-  NSLog(@"Marked as inactive");
   _active = NO;
   if (!_visible) {
     [self setApplicationState:flutter::kAppLifecycleStateHidden];
@@ -1126,15 +1123,13 @@ - (void)handleWillResignActive:(NSNotification*)notification {
 - (void)handleDidChangeOcclusionState:(NSNotification*)notification API_AVAILABLE(macos(10.9)) {
   NSApplicationOcclusionState occlusionState = [NSApp occlusionState];
   if (occlusionState & NSApplicationOcclusionStateVisible) {
-    NSLog(@"Marked as visible");
     _visible = YES;
     if (_active) {
       [self setApplicationState:flutter::kAppLifecycleStateResumed];
     } else {
       [self setApplicationState:flutter::kAppLifecycleStateInactive];
     }
   } else {
-    NSLog(@"Marked as not visible");
     _visible = NO;
     [self setApplicationState:flutter::kAppLifecycleStateHidden];
   }

shell/platform/darwin/macos/framework/Source/FlutterEngineTest.mm

@@ -788,7 +788,7 @@ - (nonnull NSView*)createWithViewIdentifier:(int64_t)viewId arguments:(nullable
   EXPECT_TRUE(announced);
 }
 
-TEST_F(FlutterEngineTest, HandleWillBecomeActive) {
+TEST_F(FlutterEngineTest, HandleLifecycleStates) {
   __block flutter::AppLifecycleState sentState;
   id engineMock = CreateMockFlutterEngine(nil);
 
@@ -816,7 +816,7 @@ - (nonnull NSView*)createWithViewIdentifier:(int64_t)viewId arguments:(nullable
       }));
 
   __block NSApplicationOcclusionState visibility = NSApplicationOcclusionStateVisible;
-  id mockApplication = OCMPartialMock(NSApp);
+  id mockApplication = OCMPartialMock([NSApplication sharedApplication]);
   OCMStub([mockApplication occlusionState]).andDo(^(NSInvocation* invocation) {
     [invocation setReturnValue:&visibility];
   });