Add text previews to widget tree #3218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (description?.isNotEmpty == true) { | ||
| yield TextSpan(text: description, style: textStyle); | ||
| } | ||
|
|
||
| final textPreview = diagnostic.json['textPreview']; | ||
| if (textPreview is String) { |
There was a problem hiding this comment.
should we be checking for is String or != null ?
There was a problem hiding this comment.
I now need to check it's a string to strip newlines from it
| @@ -0,0 +1,63 @@ | |||
| import 'package:devtools_app/src/inspector/diagnostics_node.dart'; | |||
kenzieschmoll
approved these changes
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #3195.
For now this only brings the text preview for
RenderParagraphobjects, such asTextandRichText:We probably want to support other widgets such as
SelectableText, but those will require special cases.Am in the process of adding tests hence the draft, but I wanted to check you're happy with this implementation of adding an extra polyfill script @jacob314 @kenzieschmoll?