New widget icons and alignment added (#3195) #3215
Conversation
tomgilder
force-pushed
the
redesign/widget-tree-phase2
branch
from
58123d6 to
dab2be2
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
1 similar comment
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent |
tomgilder
force-pushed
the
redesign/widget-tree-phase2
branch
from
dab2be2 to
205b536
Compare
|
Sorry to push more changes to this PR, but I think it's better to review these changes all together. The additional commit adds several more widget icons, and implements widget colors in the layout explorer. Because of showing the colors in layout explorer, the layout explorer now uses a thicker border and slight shadow to show the selected widget:
|
| @@ -0,0 +1,238 @@ | |||
| import 'package:flutter/material.dart'; | |||
There was a problem hiding this comment.
need copyright at top of file
| ), | ||
| ); | ||
| ); | ||
| }); |
| return themeMap[_stripBrackets(widgetType)] ?? const WidgetTheme(); | ||
| } | ||
|
|
||
| /// Strips the brackets of the widget |
There was a problem hiding this comment.
dartdoc nit. r/of/off and add new line after first sentence.
/// Strips the brackets off of the widget name.
///
/// For example: `AnimatedBuilder<String>` -> `AnimatedBuilder`.
| 'Scrollbar': scrollTheme, | ||
| 'ScrollConfiguration': scrollTheme, | ||
| 'GridView': WidgetTheme(iconAsset: WidgetIcons.gridView), | ||
| 'ListView': WidgetTheme(iconAsset: WidgetIcons.listView), |
There was a problem hiding this comment.
put this WidgetTheme into a const above since it is used in multiple places. Here and elsewhere for all duplicated WidgetTheme instances
Here is the PR for the new widget tree. Coloring of the widget tree and layout explorer is waiting for the new brand colors.
Before:
After: