Skip to content

ui tweaks to the splitter icon #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Conversation

devoncarew
Copy link
Member

ui tweaks to the splitter icon:

  • make the color slightly gray
  • change the splitter width to 12 px (from 24)

Screen Shot 2020-06-17 at 4 41 02 PM

Screen Shot 2020-06-17 at 4 41 06 PM

cc @kenzieschmoll

child: const Icon(
Icons.drag_handle,
size: size,
child: Align(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pq here is a simple flutter layout lint. Lint if Align is used in a case where Center would have the same effect and quick fix to using Center.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devoncarew devoncarew merged commit fcf215e into flutter:master Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants