Skip to content

[Property Editor] JIT survey #8944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
elliette opened this issue Feb 24, 2025 · 0 comments · Fixed by dart-lang/tools#2059
Closed

[Property Editor] JIT survey #8944

elliette opened this issue Feb 24, 2025 · 0 comments · Fixed by dart-lang/tools#2059
Labels
P2 important to work on, but not at the top of the work list. property editor

Comments

@elliette
Copy link
Member

elliette commented Feb 24, 2025 •
edited
Loading

We can only use the data provided in the LogStatsFile to trigger a survey: https://github.com/dart-lang/tools/blob/b51f39d01f5a4af33428a0189cd62595c01e23de/pkgs/unified_analytics/lib/src/log_handler.dart#L16

This currently only includes the count of DevTools event. We will need to modify the unified_analytics package to include Property Editor events.

We can then use that as a trigger in the context survey JSON file:

https://github.com/flutter/uxr/blob/6e4b3b5f5ba93036a4e767552bcf817a2bb0319b/surveys/contextual-survey-metadata.json
@elliette elliette added P2 important to work on, but not at the top of the work list. property editor labels Feb 24, 2025
@elliette elliette mentioned this issue Apr 4, 2025
Merged
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Apr 7, 2025
@elliette
Update and pin tools_rev
746cfdf 
Pinned due to dart-lang/tools#2034
- revert PR: dart-lang/tools#2064
- re-land PR: dart-lang/tools#2065

Bug: flutter/devtools#8944
Change-Id: I604c5dcc1e7e12b729ceb47e2549e373c4dc3c5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420801
Commit-Queue: Elliott Brooks <[email protected]>
Reviewed-by: Devon Carew <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 important to work on, but not at the top of the work list. property editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[UA] Add ability to split out sub-events in the LogStatsFile elliette/tools
1 participant
@elliette