Skip to content

Commit f8c0638

Browse files
committed
Minor changes based on reviews
* Update RenderTizenView * Update change log * Revert unintended changes * Update version Signed-off-by: MuHong Byun <[email protected]>
1 parent 6b32f0b commit f8c0638

File tree

7 files changed

+27
-250
lines changed

7 files changed

+27
-250
lines changed

packages/webview_flutter/CHANGELOG.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
## NEXT
1+
## 0.5.0
22

33
* Code refactoring.
4-
* Update the example app.
4+
* Update the example app and integration_test.
5+
* Sync with the latest framework code.
56
* Migrate to new analysis options.
67

78
## 0.4.4

packages/webview_flutter/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ This package is not an _endorsed_ implementation of `webview_flutter`. Therefore
2424

2525
```yaml
2626
dependencies:
27-
webview_flutter: ^3.0.2
28-
webview_flutter_tizen: ^0.4.4
27+
webview_flutter: ^3.0.4
28+
webview_flutter_tizen: ^0.5.0
2929
```
3030
3131
## Example

packages/webview_flutter/example/tizen/tizen-manifest.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8"?>
22
<manifest package="org.tizen.webview_flutter_tizen_example" version="1.0.0" api-version="5.5" xmlns="http://tizen.org/ns/packages">
3-
<profile name="mobile"/>
3+
<profile name="common"/>
44
<ui-application appid="org.tizen.webview_flutter_tizen_example" exec="Runner.dll" type="dotnet" multiple="false" taskmanage="true" nodisplay="false" api-version="4" launch_mode="single">
55
<label>webview_flutter_tizen_example</label>
66
<icon>ic_launcher.png</icon>

packages/webview_flutter/lib/src/platform_view.dart

Lines changed: 0 additions & 228 deletions
This file was deleted.

packages/webview_flutter/lib/src/platform_view_tizen.dart

Lines changed: 19 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,12 @@
1414

1515
part of '../webview_flutter_tizen.dart';
1616

17+
enum _PlatformViewState {
18+
uninitialized,
19+
resizing,
20+
ready,
21+
}
22+
1723
class TizenView extends StatefulWidget {
1824
const TizenView({
1925
Key? key,
@@ -144,7 +150,6 @@ class _TizenWebViewState extends State<TizenView> {
144150
if (!_controller.isCreated) {
145151
return;
146152
}
147-
148153
if (!isFocused) {
149154
_controller.clearFocus().catchError((dynamic e) {
150155
if (e is MissingPluginException) {
@@ -153,12 +158,10 @@ class _TizenWebViewState extends State<TizenView> {
153158
});
154159
return;
155160
}
156-
SystemChannels.textInput
157-
.invokeMethod<void>(
161+
SystemChannels.textInput.invokeMethod<void>(
158162
'TextInput.setPlatformViewClient',
159-
_id,
160-
)
161-
.catchError((dynamic e) {
163+
<String, dynamic>{'platformViewId': _id},
164+
).catchError((dynamic e) {
162165
if (e is MissingPluginException) {
163166
return;
164167
}
@@ -457,7 +460,7 @@ class PlatformViewsServiceTizen {
457460
/// See also:
458461
///
459462
/// * [PlatformViewsService] which is a service for controlling platform views.
460-
class RenderTizenView extends RenderBox with _PlatformViewGestureMixin {
463+
class RenderTizenView extends PlatformViewRenderBox {
461464
/// Creates a render object for an Tizen view.
462465
RenderTizenView({
463466
required TizenViewController viewController,
@@ -467,8 +470,13 @@ class RenderTizenView extends RenderBox with _PlatformViewGestureMixin {
467470
}) : assert(viewController != null),
468471
assert(hitTestBehavior != null),
469472
assert(gestureRecognizers != null),
473+
assert(clipBehavior != null),
470474
_viewController = viewController,
471-
_clipBehavior = clipBehavior {
475+
_clipBehavior = clipBehavior,
476+
super(
477+
controller: viewController,
478+
hitTestBehavior: hitTestBehavior,
479+
gestureRecognizers: gestureRecognizers) {
472480
updateGestureRecognizers(gestureRecognizers);
473481
_viewController.addOnPlatformViewCreatedListener(_onPlatformViewCreated);
474482
this.hitTestBehavior = hitTestBehavior;
@@ -478,12 +486,15 @@ class RenderTizenView extends RenderBox with _PlatformViewGestureMixin {
478486

479487
Size? _currentTextureSize;
480488

489+
@override
481490
TizenViewController get controller => _viewController;
491+
482492
TizenViewController _viewController;
483493

484494
/// Sets a new Tizen view controller.
485495
///
486496
/// `viewController` must not be null.
497+
@override
487498
set controller(TizenViewController viewController) {
488499
assert(_viewController != null);
489500
assert(viewController != null);
@@ -517,12 +528,6 @@ class RenderTizenView extends RenderBox with _PlatformViewGestureMixin {
517528
markNeedsSemanticsUpdate();
518529
}
519530

520-
void updateGestureRecognizers(
521-
Set<Factory<OneSequenceGestureRecognizer>> gestureRecognizers) {
522-
_updateGestureRecognizersWithCallBack(
523-
gestureRecognizers, _viewController.dispatchPointerEvent);
524-
}
525-
526531
@override
527532
bool get sizedByParent => true;
528533

packages/webview_flutter/lib/webview_flutter_tizen.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ import 'package:flutter/widgets.dart';
1515
import 'package:webview_flutter/webview_flutter.dart';
1616
import 'package:webview_flutter_platform_interface/webview_flutter_platform_interface.dart';
1717

18-
part 'src/platform_view.dart';
1918
part 'src/platform_view_tizen.dart';
2019

2120
/// Builds an Tizen webview.

packages/webview_flutter/pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,10 @@ name: webview_flutter_tizen
22
description: Tizen implementation of the webview plugin
33
homepage: https://github.com/flutter-tizen/plugins
44
repository: https://github.com/flutter-tizen/plugins/tree/master/packages/webview_flutter
5-
version: 0.4.4
5+
version: 0.5.0
66

77
environment:
8-
sdk: ">=2.14.0 <3.0.0"
8+
sdk: ">=2.17.0 <3.0.0"
99
flutter: ">=2.8.0"
1010

1111
flutter:

0 commit comments

Comments
 (0)