Skip to content

Commit 8202f13

Browse files
committed
Remove pigeon path and fix return fail case issue
1 parent b1b585f commit 8202f13

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

packages/video_player_videohole/pubspec.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,4 +26,3 @@ dev_dependencies:
2626
sdk: flutter
2727
pedantic: ^1.10.0
2828
pigeon:
29-
path: /home/hyue/Tizen/pigeon

packages/video_player_videohole/tizen/src/video_player_tizen_plugin.cc

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,13 @@ ErrorOr<std::unique_ptr<PlayerMessage>> VideoPlayerTizenPlugin::Create(
8888
const CreateMessage &createMsg) {
8989
std::unique_ptr<VideoPlayer> player =
9090
std::make_unique<VideoPlayer>(registrar_ref_, createMsg);
91-
int64_t playerId = player->Create();
92-
players_[playerId] = std::move(player);
9391
std::unique_ptr<PlayerMessage> player_message =
9492
std::make_unique<PlayerMessage>();
95-
player_message->set_player_id(playerId);
93+
int64_t playerId = player->Create();
94+
if (playerId != -1) {
95+
players_[playerId] = std::move(player);
96+
player_message->set_player_id(playerId);
97+
}
9698
return ErrorOr<PlayerMessage>::MakeWithUniquePtr(std::move(player_message));
9799
}
98100

0 commit comments

Comments
 (0)