Skip to content

Conversation

@molihh
Copy link
Contributor

@molihh molihh commented Mar 16, 2025

Ⅰ. Describe what this PR does

     This PR adds detailed comments to the function TestOptimizeDefaultForFuseWithArgs(t *testing.T) located in pkg/ddc/alluxio/transform_optimization_test.go. The comments clarify the purpose of the test, key logic steps, and expected outcomes to improve code readability and maintainability.

Ⅱ. Does this pull request fix one issue?

fixes #4703

Ⅲ. Special notes for reviews

PR submitted by molihh.
Focus review on:
1.Clarity and accuracy of the added comments.
2.Whether the comments align with the test logic and cover critical aspects.
3.Suggestions for further improvements to the comments or test logic.

@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Mar 16, 2025

Hi @molihh. Thanks for your PR.

I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

// - Expected Outcome: Automatic injection of mount path "/mnt/runtime" and root directory "/" arguments
// - Verification Protocol: Rigorous assertion of argument list completeness including appended paths
//
//
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many blank lines, please leave only one. Thanks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK,i will make modifications according to your suggestions

@JiGuoDing
Copy link
Collaborator

Hello @molihh,

@sonarqubecloud
Copy link

@molihh molihh closed this Jun 1, 2025
@molihh molihh deleted the mynewbranch branch June 1, 2025 03:49
@molihh molihh restored the mynewbranch branch June 1, 2025 04:15
@molihh molihh deleted the mynewbranch branch June 1, 2025 04:18
@molihh molihh restored the mynewbranch branch June 1, 2025 04:18
@molihh molihh reopened this Jun 1, 2025
molihh added 7 commits June 1, 2025 12:22
Sign-off-by: molihh <[email protected]>
Signed-off-by: molihh <[email protected]>
…kg\ddc\alluxio\transform_optimization_test.go

Sign-off-by: molihh <[email protected]>
Signed-off-by: molihh <[email protected]>
…kg\ddc\alluxio\transform_optimization_test.go

Sign-off-by: molihh <[email protected]>
Signed-off-by: molihh <[email protected]>
…kg\ddc\alluxio\transform_optimization_test.go

Sign-off-by: molihh <[email protected]>
Signed-off-by: molihh <[email protected]>
Signed-off-by: molihh <[email protected]>
Signed-off-by: molihh <[email protected]>
Signed-off-by: molihh <[email protected]>
…kg\ddc\alluxio\transform_optimization_test.go

Signed-off-by: molihh <[email protected]>
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint check issue by running make fmt

Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not acceptable that some many files have been changed.

Signed-off-by: molihh <[email protected]>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 5, 2025

@molihh molihh requested review from JiGuoDing and cheyang June 5, 2025 13:51
Copy link
Collaborator

@cheyang cheyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Jun 9, 2025
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Jun 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheyang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cheyang cheyang merged commit dd1aff5 into fluid-cloudnative:master Jun 10, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments to TestOptimizeDefaultForFuseWithArgs(t *testing.T) in pkg\ddc\alluxio\transform_optimization_test.go

3 participants