-
Notifications
You must be signed in to change notification settings - Fork 1.1k
This PR is to add comments to TestOptimizeDefaultForFuseWithArgs(t *testing.T) in pkg\ddc\alluxio\transform_optimization_test.go. #4704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @molihh. Thanks for your PR. I'm waiting for a fluid-cloudnative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| // - Expected Outcome: Automatic injection of mount path "/mnt/runtime" and root directory "/" arguments | ||
| // - Verification Protocol: Rigorous assertion of argument list completeness including appended paths | ||
| // | ||
| // |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are too many blank lines, please leave only one. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK,i will make modifications according to your suggestions
|
Hello @molihh,
|
|
Sign-off-by: molihh <[email protected]> Signed-off-by: molihh <[email protected]>
…kg\ddc\alluxio\transform_optimization_test.go Sign-off-by: molihh <[email protected]> Signed-off-by: molihh <[email protected]>
…kg\ddc\alluxio\transform_optimization_test.go Sign-off-by: molihh <[email protected]> Signed-off-by: molihh <[email protected]>
…kg\ddc\alluxio\transform_optimization_test.go Sign-off-by: molihh <[email protected]> Signed-off-by: molihh <[email protected]>
Signed-off-by: molihh <[email protected]>
Signed-off-by: molihh <[email protected]>
Signed-off-by: molihh <[email protected]>
…kg\ddc\alluxio\transform_optimization_test.go Signed-off-by: molihh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the lint check issue by running make fmt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not acceptable that some many files have been changed.
Signed-off-by: molihh <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |



Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
fixes #4703
Ⅲ. Special notes for reviews
PR submitted by molihh.
Focus review on:
1.Clarity and accuracy of the added comments.
2.Whether the comments align with the test logic and cover critical aspects.
3.Suggestions for further improvements to the comments or test logic.