Make fluentbit livenessProbe more flexible #1628
Merged
+6
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Siarhei Rasiukevich <[email protected]>
cw-Guo
approved these changes
Jun 5, 2025
|
Thanks for contribution! @CharlieR-o-o-t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We still encounter hangs during logs reopen (on rotation), fluent reloads. Seems that it's related to issue: fluent/fluent-bit#5485
What we can do quick - is to analyze metrics of fluent (fluentbit_input_records_total) in livenessProbes and trigger pod restart if no logs on input during some time specified.
I want to be able to use not only http probe, but any definition possible for livenessProbe.
PR does not have breaking changes, yaml will be generated the same as in previous version.