Enable defining a handler for buffer overflow when using the library as a python logging handler #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as a python logging handler
repeatedly
reviewed
Jan 26, 2017
| @@ -188,7 +188,7 @@ module. | |||
|
|
|||
| logging.basicConfig(level=logging.INFO) | |||
| l = logging.getLogger('fluent.test') | |||
| h = handler.FluentHandler('app.follow', host='host', port=24224) | |||
| h = handler.FluentHandler('app.follow', host='host', port=24224, buffer_overflow_handler=handler) | |||
There was a problem hiding this comment.
Could you add handler code like Sender example?
There was a problem hiding this comment.
This example seems incorrect since handler is a module (from fluent import handler). buffer_overflow_handler should be a callable.
There was a problem hiding this comment.
I sent pull request to avoid variable name confliction by changing variable name in example:
#87
…e a buffer overflow example
montaro
commented
Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.