Merge pull request #204 from fchapoton/cython-lint

first sketch of cython-lint workflow

Author: oscarbenjamin

.github/workflows/lint.yml

@@ -0,0 +1,26 @@
+name: Linting
+
+on: [push, pull_request]
+
+jobs:
+  lint:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        python-version: ["3.11", "3.12"]
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Set up Python ${{ matrix.python-version }}
+      uses: actions/setup-python@v5
+      with:
+        python-version: ${{ matrix.python-version }}
+
+    - name: Install dependencies
+      run: |
+        pip install uv
+        uv pip install cython-lint --upgrade --system
+
+    - name: cython-lint
+      run: |
+        cython-lint src/

pyproject.toml

@@ -39,6 +39,11 @@ content-type = "text/markdown"
 requires = ["meson-python>=0.13", "cython>=3.0,<3.1"]
 build-backend = "mesonpy"
 
+[tool.cython-lint]
+max-line-length = 120
+ignore = ['E114','E117','E127','E128','E129','E202','E221','E222','E231','E261','E262','E265','E302','E303','E306','E501','E701','E703','E711','E722','E731','E741','E743','W391']
+exclude = 'src/flint/flintlib/.*'
+
 [tool.spin]
 package = "flint"
 

src/flint/pyflint.pyx

@@ -2,9 +2,8 @@
 Python wrapper for FLINT and Arb.
 """
 
-cimport flint
+# cimport flint
 cimport libc.stdlib
-cimport cython
 
 from flint.flint_base.flint_context cimport thectx
 

src/flint/types/acb.pyx

@@ -87,15 +87,15 @@ cdef any_as_acb_or_notimplemented(x):
         return NotImplemented
     return t
 
-"""
-cdef any_as_arb_or_acb(x):
-    if typecheck(x, arb) or typecheck(x, acb):
-        return x
-    try:
-        return arb(x)
-    except (TypeError, ValueError):
-        return acb(x)
-"""
+
+# cdef any_as_arb_or_acb(x):
+#     if typecheck(x, arb) or typecheck(x, acb):
+#         return x
+#     try:
+#         return arb(x)
+#     except (TypeError, ValueError):
+#         return acb(x)
+
 
 
 # Copied with modifications from sage/rings/complex_arb.pyx
@@ -2387,7 +2387,7 @@ cdef class acb(flint_scalar):
         of terms to add in the hypergeometric series. This is just a tuning
         parameter: a rigorous error bound is computed regardless of *n*.
         """
-        cdef long i, p, q, prec
+        cdef long i, p, q
         cdef acb_ptr aa, bb
         a = [any_as_acb(t) for t in a]
         b = [any_as_acb(t) for t in b]

src/flint/types/acb_mat.pyx

@@ -331,7 +331,6 @@ cdef class acb_mat(flint_mat):
         return u
 
     def __truediv__(s, t):
-        cdef acb_mat u
         if typecheck(s, acb_mat):
             s, t = acb_mat_coerce_scalar(s, t)
             if s is NotImplemented:
@@ -597,7 +596,6 @@ cdef class acb_mat(flint_mat):
         return u
 
     def __richcmp__(s, t, int op):
-        cdef int stype, ttype
         cdef bint res
         if not (op == 2 or op == 3):
             raise ValueError("comparing matrices")

src/flint/types/acb_poly.pyx

@@ -363,7 +363,7 @@ cdef class acb_poly(flint_poly):
             ValueError: roots() failed to converge: insufficient precision, or squareful input
 
         """
-        cdef long prec, initial_prec, target_prec, isolated, maxiter, deg, i
+        cdef long prec, initial_prec, isolated, maxiter, deg, i
         cdef acb_ptr roots
         cdef acb_poly_t tmp
         deg = s.degree()

src/flint/types/acb_series.pyx

@@ -8,7 +8,6 @@ from flint.types.acb cimport acb
 from flint.types.fmpz_poly cimport fmpz_poly
 from flint.types.fmpq_poly cimport fmpq_poly
 from flint.types.arb_poly cimport arb_poly
-from flint.types.arb_poly cimport arb_poly_set_list
 from flint.types.acb_poly cimport acb_poly_set_list
 from flint.types.arb cimport arb
 from flint.types.acb_poly cimport acb_poly
@@ -629,7 +628,7 @@ cdef class acb_series(flint_series):
         of terms to add in the hypergeometric series. This is just a tuning
         parameter: a rigorous error bound is computed regardless of *n*.
         """
-        cdef long i, p, q, prec, cap
+        cdef long i, p, q, cap
         cdef acb_poly_struct * aa
         cdef acb_poly_struct * bb
         a = [acb_series(t) for t in a]

src/flint/types/arb.pyx

@@ -5,7 +5,7 @@ from flint.flint_base.flint_context cimport getprec
 from flint.flint_base.flint_context cimport thectx
 from flint.flint_base.flint_base cimport flint_scalar
 from flint.utils.typecheck cimport typecheck
-from flint.utils.conversion cimport chars_from_str, str_from_chars, _str_trunc
+from flint.utils.conversion cimport chars_from_str, str_from_chars
 from flint.types.fmpz cimport fmpz_set_pylong
 from flint.types.arf cimport arf
 from flint.types.fmpq cimport fmpq
@@ -43,7 +43,7 @@ cdef arb_from_str(str s):
         raise ValueError("invalid string for arb()")
 
 cdef arb_set_mpmath_mpf(arb_t x, obj):
-    sgn, man, exp, bc = obj
+    sgn, man, exp, _ = obj
 
     if not man:
         if not exp:
@@ -2171,7 +2171,7 @@ cdef class arb(flint_scalar):
             >>> showgood(lambda: arb(5).hypgeom([1,2,3],[5,4.5,6],regularized=True), dps=25)
             3.886189282817193519132054e-5
         """
-        cdef long i, p, q, prec
+        cdef long i, p, q
         cdef arb_ptr aa, bb
         a = [any_as_arb(t) for t in a]
         b = [any_as_arb(t) for t in b]

src/flint/types/arb_mat.pyx

@@ -300,7 +300,6 @@ cdef class arb_mat(flint_mat):
         return u
 
     def __rmul__(s, t):
-        cdef arb_mat u
         c, d = arb_mat_coerce_scalar(s, t)
         if c is not NotImplemented:
             return c._scalar_mul_(d)
@@ -317,7 +316,6 @@ cdef class arb_mat(flint_mat):
         return u
 
     def __truediv__(s, t):
-        cdef arb_mat u
         s, t = arb_mat_coerce_scalar(s, t)
         if s is NotImplemented:
             return s
@@ -669,7 +667,6 @@ cdef class arb_mat(flint_mat):
         return u
 
     def __richcmp__(s, t, int op):
-        cdef int stype, ttype
         cdef bint res
         if not (op == 2 or op == 3):
             raise ValueError("comparing matrices")

src/flint/types/arb_poly.pyx

@@ -14,7 +14,6 @@ from flint.types.acb_poly cimport acb_poly
 
 from flint.flintlib.arb cimport *
 from flint.flintlib.arb_poly cimport *
-cimport cython
 cimport libc.stdlib
 
 cdef arb_poly_coerce_operands(x, y):