Skip to content

Don't clear $FLAGS and rename to $ELECTRON_FLAGS #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 30, 2022
Merged

Don't clear $FLAGS and rename to $ELECTRON_FLAGS #20

merged 5 commits into from
Sep 30, 2022

Conversation

sebastian-de
Copy link
Contributor

@sebastian-de sebastian-de commented Sep 30, 2022

That way $ELECTRON_FLAGS can be passed to the IDE. Corresponding README section added.

(Also removes one trailing whitespace in README.md).

That way $ELECTRON_FLAGS can be passed to the IDE. Corresponding README section added.
@flathubbot
Copy link
Contributor

Started test build 113316

@flathubbot
Copy link
Contributor

Build 113316 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/110918/cc.arduino.IDE2.flatpakref

@sebastian-de
Copy link
Contributor Author

Following up the discussion from #18
With this commit, one can enable Wayland locally by running

flatpak override --user --socket=wayland cc.arduino.IDE2
flatpak override --user --env=ELECTRON_FLAGS="--enable-features=UseOzonePlatform --ozone-platform=wayland" cc.arduino.IDE2

without the need to patch arduino-ide.sh.

@SuperNinja-4965
Copy link
Collaborator

Following up the discussion from #18 With this commit, one can enable Wayland locally by running

flatpak override --user --socket=wayland cc.arduino.IDE2
flatpak override --user --env=ELECTRON_FLAGS="--enable-features=UseOzonePlatform --ozone-platform=wayland" cc.arduino.IDE2

without the need to patch arduino-ide.sh.

I initially didnt see the point in making this change but i can now see what you are trying to do here.
im hesitant to rename any variable to have the word electron in them incase they get used be electron somewhere down the line (especially with such a generic name).
Im going to rename your variable a little and since you decided to clear the whitespace lets use proper english and put a : there instead.

@flathubbot

This comment was marked as outdated.

@SuperNinja-4965
Copy link
Collaborator

I have renamed ELECTRON_FLAGS to CUSTOM_IDE_FLAGS as this could be used for other flags for the ide too in theory and it keeps the variable's purpose obvious.

@sebastian-de
Copy link
Contributor Author

I have renamed ELECTRON_FLAGS to CUSTOM_IDE_FLAGS as this could be used for other flags for the ide too in theory and it keeps the variable's purpose obvious.

Sure, I just didn't want to keep the too generic FLAGS.

@SuperNinja-4965
Copy link
Collaborator

I have renamed ELECTRON_FLAGS to CUSTOM_IDE_FLAGS as this could be used for other flags for the ide too in theory and it keeps the variable's purpose obvious.

Sure, I just didn't want to keep the too generic FLAGS.

that's fine and makes sense if we are going to enable support for flatpak override to be used like this.
I have also tidied up the readme a little.
Once the test build is done and i have tested to make sure all is good I will merge this as i cant see a reason why not.

@flathubbot

This comment was marked as outdated.

@SuperNinja-4965
Copy link
Collaborator

bot, build

@flathubbot
Copy link
Contributor

Queued test build for cc.arduino.IDE2.

@flathubbot
Copy link
Contributor

Started test build 113355

@flathubbot
Copy link
Contributor

Build 113355 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/110957/cc.arduino.IDE2.flatpakref

@SuperNinja-4965 SuperNinja-4965 merged commit 8626d63 into flathub:master Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants