-
Notifications
You must be signed in to change notification settings - Fork 5
Don't clear $FLAGS and rename to $ELECTRON_FLAGS #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That way $ELECTRON_FLAGS can be passed to the IDE. Corresponding README section added.
Started test build 113316 |
Build 113316 successful
|
Following up the discussion from #18 flatpak override --user --socket=wayland cc.arduino.IDE2
flatpak override --user --env=ELECTRON_FLAGS="--enable-features=UseOzonePlatform --ozone-platform=wayland" cc.arduino.IDE2 without the need to patch |
I initially didnt see the point in making this change but i can now see what you are trying to do here. |
This comment was marked as outdated.
This comment was marked as outdated.
I have renamed ELECTRON_FLAGS to CUSTOM_IDE_FLAGS as this could be used for other flags for the ide too in theory and it keeps the variable's purpose obvious. |
Sure, I just didn't want to keep the too generic FLAGS. |
that's fine and makes sense if we are going to enable support for flatpak override to be used like this. |
This comment was marked as outdated.
This comment was marked as outdated.
bot, build |
Queued test build for cc.arduino.IDE2. |
Started test build 113355 |
Build 113355 successful
|
That way
$ELECTRON_FLAGS
can be passed to the IDE. Corresponding README section added.(Also removes one trailing whitespace in README.md).