[flang][fir] Add external name mangling pass #1061
Conversation
clementval
force-pushed
the
externalabi
branch
from
8c3cd77 to
ca5d512
Compare
There was a problem hiding this comment.
Looks great to me. I wondering if this should be run by default by tco or not. Since tco is not a real Fortran driver, I guess it's OK to not run this pass by default.
Regarding the pass name, I am OK with it, the pedantic comment would be that --external-abi might be a bit too generic since this is only dealing with the naming part of the ABI and that the target-rewrite pass (declared here) pass is also somehow Fortran ABI related. So --external-name-abi might be more descriptive, but wait for @schweitzpgi takes on this before changing it.
clementval
force-pushed
the
externalabi
branch
from
ca5d512 to
f83e4ac
Compare
clementval
changed the title
clementval
force-pushed
the
externalabi
branch
from
f83e4ac to
cf4fd39
Compare
Thanks for the review. I renamed most of the ABI into Name and the pass option is now |
The added pass works when mlir::LLVM::LLVMDialect, mlir::acc::OpenACCDialect, and mlir::omp::OpenMPDialect are present, which adds a dependency on those dialect libraries. https://github.com/flang-compiler/f18-llvm-project/blob/bb1ab876a5fec1eb3f2ab0603756f9124515a68a/flang/include/flang/Optimizer/Transforms/Passes.td#L189
The added pass works when mlir::LLVM::LLVMDialect, mlir::acc::OpenACCDialect, and mlir::omp::OpenMPDialect are present, which adds a dependency on those dialect libraries. https://github.com/flang-compiler/f18-llvm-project/blob/bb1ab876a5fec1eb3f2ab0603756f9124515a68a/flang/include/flang/Optimizer/Transforms/Passes.td#L189
The patch add a new pass called
ExternalNameConversion. It converts the FIR internal name with the gfortran external name convention.The pass is not applied by default in
tco.